Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Table Cell id prop back into the Cell types #7983

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Mar 24, 2025

Closes

https://github.com/adobe/react-spectrum/pull/7843/files#r2010690783

TL;DR
I moved this prop instead of copying it into the block above

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger mentioned this pull request Mar 24, 2025
5 tasks
@rspbot
Copy link

rspbot commented Mar 24, 2025

@rspbot
Copy link

rspbot commented Mar 24, 2025

## API Changes

react-aria-components

/react-aria-components:Cell

 Cell {
   children?: ReactNode | ((CellRenderProps & {
     defaultChildren: ReactNode | undefined
 })) => ReactNode
   className?: string | ((CellRenderProps & {
     defaultClassName: string | undefined
 })) => string
   colSpan?: number
+  id?: Key
   style?: CSSProperties | ((CellRenderProps & {
     defaultStyle: CSSProperties
 })) => CSSProperties | undefined
   textValue?: string

/react-aria-components:CellProps

 CellProps {
   children?: ReactNode | ((CellRenderProps & {
     defaultChildren: ReactNode | undefined
 })) => ReactNode
   className?: string | ((CellRenderProps & {
     defaultClassName: string | undefined
 })) => string
   colSpan?: number
+  id?: Key
   style?: CSSProperties | ((CellRenderProps & {
     defaultStyle: CSSProperties
 })) => CSSProperties | undefined
   textValue?: string

@react-spectrum/s2

/@react-spectrum/s2:Cell

 Cell {
   align?: 'start' | 'center' | 'end' = 'start'
   children: ReactNode
   className?: string | ((CellRenderProps & {
     defaultClassName: string | undefined
 })) => string
   colSpan?: number
+  id?: Key
   showDivider?: boolean
   style?: CSSProperties | ((CellRenderProps & {
     defaultStyle: CSSProperties
 })) => CSSProperties | undefined
 }

/@react-spectrum/s2:CellProps

 CellProps {
   align?: 'start' | 'center' | 'end' = 'start'
   children: ReactNode
   className?: string | ((CellRenderProps & {
     defaultClassName: string | undefined
 })) => string
   colSpan?: number
+  id?: Key
   showDivider?: boolean
   style?: CSSProperties | ((CellRenderProps & {
     defaultStyle: CSSProperties
 })) => CSSProperties | undefined
 }

@snowystinger snowystinger added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit d7511d7 Mar 25, 2025
31 checks passed
@snowystinger snowystinger deleted the fix-removed-id-prop branch March 25, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants