Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up some form of CI #38

Closed
thomasvl opened this issue Oct 4, 2016 · 4 comments
Closed

Set up some form of CI #38

thomasvl opened this issue Oct 4, 2016 · 4 comments
Assignees

Comments

@thomasvl
Copy link
Collaborator

thomasvl commented Oct 4, 2016

Maybe https://swift.org/continuous-integration can be leveraged, but something should likely get set up to test things as they land and to test PRs as they come in.

@fabiomassimo
Copy link

Would a free solution for open source projects, like Travis, be a valid option for you?

@timburks
Copy link

timburks commented Apr 13, 2017

+1 for Travis. The grpc-swift Travis tests recently failed with the following:

/home/travis/build/grpc/grpc-swift/Plugin/Packages/SwiftProtobuf-0.9.29/Sources/SwiftProtobuf/Google_Protobuf_Any+Registry.swift:50:31: error: use of unresolved identifier 'DispatchQueue'
fileprivate var serialQueue = DispatchQueue(label: "com.apple.swift.typeRegistry")

The problem appears to be that "import DispatchQueue" is only necessary on Linux. Since Travis tests run on Linux, it's likely that this would have been caught here.

EDIT: I see that the build failure was fixed in this commit.

@thomasvl
Copy link
Collaborator Author

#973 just added GitHub actions for a linux build.

@thomasvl
Copy link
Collaborator Author

Closing this since the linux CI actions are now running on PRs.

ahmed-osama-saad pushed a commit to ahmed-osama-saad/swift-protobuf that referenced this issue Oct 12, 2023
…scan-screen

Improve the architecture of the example app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants