You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Protos directory contains a bunch of protos taken from google/protobuf, the reality is they need to stay stay in sync (especially things for the plugin and the Well Known Types).
An ideal setup would likely to be try and pull them via a gitmodule so they always are in sync. Short of that, something should be done to automate updating them.
Maybe once there is a CI system (#38), it could check/error if they need updating.
The text was updated successfully, but these errors were encountered:
The plugin and well known types definitely should be synced somehow. A gitmodule approach is certainly worth considering. At one time, I had a Makefile target to copy the files from google/protobuf.
For the rest, I could go either way. They could be synced or not. Syncing them benefits from new cases added upstream, but diminishes their usefulness for generator testing.
PR #150 added a makefile target that will sync things. Keeping this open as it would be nice to have things automatically done instead of a manual process.
The
Protos
directory contains a bunch of protos taken from google/protobuf, the reality is they need to stay stay in sync (especially things for the plugin and the Well Known Types).An ideal setup would likely to be try and pull them via a gitmodule so they always are in sync. Short of that, something should be done to automate updating them.
Maybe once there is a CI system (#38), it could check/error if they need updating.
The text was updated successfully, but these errors were encountered: