Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate/improve the dependency on google/protobuf #42

Closed
thomasvl opened this issue Oct 4, 2016 · 3 comments
Closed

Automate/improve the dependency on google/protobuf #42

thomasvl opened this issue Oct 4, 2016 · 3 comments
Labels
kind/enhancement Improvements to existing feature.

Comments

@thomasvl
Copy link
Collaborator

thomasvl commented Oct 4, 2016

The Protos directory contains a bunch of protos taken from google/protobuf, the reality is they need to stay stay in sync (especially things for the plugin and the Well Known Types).

An ideal setup would likely to be try and pull them via a gitmodule so they always are in sync. Short of that, something should be done to automate updating them.

Maybe once there is a CI system (#38), it could check/error if they need updating.

@tbkka
Copy link
Collaborator

tbkka commented Oct 4, 2016

The plugin and well known types definitely should be synced somehow. A gitmodule approach is certainly worth considering. At one time, I had a Makefile target to copy the files from google/protobuf.

For the rest, I could go either way. They could be synced or not. Syncing them benefits from new cases added upstream, but diminishes their usefulness for generator testing.

@thomasvl thomasvl added the kind/enhancement Improvements to existing feature. label Oct 18, 2016
@thomasvl
Copy link
Collaborator Author

thomasvl commented Dec 1, 2016

PR #150 added a makefile target that will sync things. Keeping this open as it would be nice to have things automatically done instead of a manual process.

@thomasvl
Copy link
Collaborator Author

Closing this since #1005 adds an easy way to check this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements to existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants