Change error output color to brighter orange

[ghost]

Addressed issue #7451 by changing the color of error output to a brighter orange color.

[matthijskooijman]

Looks good. Care to add a screenshot of how this looks (and let's try to prevent too much bikeshedding :-p).

[ghost]

Sure! I'm including a screenshot with three different colors for error output. The leftmost one is the original color, the middle is an intermediate color I tested, and the rightmost one is the final color I committed.

[facchinm]

@00alis what about it?

[ghost]

Hello, I just went back to the issue request that requested this fix and realized that the problem was not the brightness of the orange color, but certain colors in general. I am including a picture with the error output color in white (what the person is now asking for). I originally did not stray from the color orange because I did not want to break the traditional look, but maybe the change to white could help make the IDE more accessible.

[per1234]

I put this PR on hold because feedback indicates it does not at all resolve #7451.

[00alis]

I agree the colors are hard to read on certain screens, it is quite an hard task to make it work everywhere. On the Web IDE we are using the following palette:
Green (debug content, does not appear if you turn off Show Verbose output) #1da086
White (normal output)
Yellow (warning) #F1C40F
Red (error) #DA5B4A

Would you mind applying the same palette to your PR and let us know your thoughts?

[matthijskooijman]

Note that the web IDE does not currently distinguish warnings and debug output, though I believe to some degree it could (for warnings/debug output generated by the IDE itself or arduino-builder, not for external processes like the compiler).

[lmihalkovic]

I did this in my local IDE. It is a trivial task and not much more work to extend the coloring to the entire lines (actually easier than to paint only a small part of the message). The part that is highlighted navigates to the relevant part of the source code.. personally, I find it useful (motivated me to chase all the warnings in my code)

I'll try with the unofficial-official colors.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Alogitt seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}