Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy button to the serial monitor #8640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pieter12345
Copy link
Contributor

@Pieter12345 Pieter12345 commented Mar 11, 2019

Add a copy button to the serial monitor that copies the text in the serial monitor output area to the system clipboard. This is useful since ctrl-a + ctrl-c does not work when the serial monitor is spammed at a high rate.

Related: arduino/arduino-ide#1729.

@facchinm
Copy link
Member

@ArduinoBot build this please

@per1234 per1234 added the Component: IDE Serial monitor Tools > Serial Monitor label Mar 12, 2019
@Pieter12345 Pieter12345 force-pushed the serial-monitor-copy-btn branch from e4a7ac1 to 97e979c Compare March 18, 2019 16:40
@Pieter12345
Copy link
Contributor Author

Rebased onto master (force-push). No additional changes were made.

@facchinm
Copy link
Member

I just started to wonder if we can avoid the button by adding a contextual menu on the serial monitor itself with 2 entries:

@per1234
Copy link
Collaborator

per1234 commented Mar 20, 2019

I like the context menu idea. It seems like a fairly intuitive UI.

@tigoe
Copy link
Member

tigoe commented Mar 20, 2019

My usual solution to this is to turn off autoscroll, then use a crtl-A, crtl-C. It makes me think it's worth adding a keyboard control for autoscroll, so you could use keys to do this all the way through. Would be better for accessibility too. context menus can be a pain for screen readers.

Add a copy button to the serial monitor that copies the text in the serial monitor output area to the system clipboard.
@Pieter12345 Pieter12345 force-pushed the serial-monitor-copy-btn branch from 97e979c to 14fb227 Compare March 29, 2019 01:05
@Pieter12345
Copy link
Contributor Author

Rebased this PR onto master.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE Serial monitor Tools > Serial Monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants