Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PyInstaller 6.11.1 #9382

Merged
merged 3 commits into from
Mar 20, 2025
Merged

Upgrade to PyInstaller 6.11.1 #9382

merged 3 commits into from
Mar 20, 2025

Conversation

ashovlin
Copy link
Member

Issue #, if available: This reapplies our PyInstaller 6 upgrade from #9194 which was reverted via #9332, with fixes for the two issues that led to the revert:

  1. PyInstaller update causes libsqlite3.so ImportError with nested aws cli in credential_process #9336 -> Set PYINSTALLER_RESET_ENVIRONMENT automatically when launching subprocesses #9369
  2. Unable to build 2.24.14 in Alpine 3.20, Python 3.11.11 #9331 -> Only run symlink verification for Darwin during installer builds #9379

Description of changes: This cherry-picks the original commit from merging #9194, with the two additional PRs listed above applied on top of it.

[In Progress] Repeating our installer verification steps from the internal runbook

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

kdaily and others added 3 commits March 14, 2025 10:29
* Bump PyInstaller to 6.11.1
This includes pinning `macholib` because of this change in `PyInstaller`
that makes `macholib` a build dependency.

pyinstaller/pyinstaller#5883

---------

Co-authored-by: Github Actions <>
Co-authored-by: Steve Yoo <hssyoo@amazon.com>
Co-authored-by: Alex Shovlin <shovlia@amazon.com>
@hssyoo hssyoo self-assigned this Mar 18, 2025
Copy link
Contributor

@hssyoo hssyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming installer validation looks good 🏆

@ashovlin ashovlin merged commit f486310 into v2 Mar 20, 2025
90 checks passed
@ashovlin ashovlin deleted the feature/pyinstaller-6 branch March 20, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants