Enable integration with fixed, non-uniform schedule. #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables specialized, manually specified schedules, as for example required in diffusion models for inference. Closes bayesflow-org#402.
Codecov ReportAttention: Patch coverage is
|
|
Looks great, thank you for the PR. @vpratz can you please re-merge dev into this and see if tests pass? Ready to merge from my side otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables specialized, manually specified schedules, as for example required in diffusion models for inference.
Regarding the changes in
integrate: I changed thematch-caseto anif-elsestructure, as I was not able to express it properly otherwise, as custom types likeTensorseem not to be easily compatible with match statements. If you want to keep the match statement and know how to do it, feel free to change it.I'm also not sure whether we want to allow
Sequencein general (lists, tuples, ...), or only numpy arrays and tensors.If you have any thoughts, please let me know.
Closes #402.