-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change word length due to error on mechanical-markdown #1279
Conversation
0c17158
to
3e54d98
Compare
@mcruzdev looking at the code changes.. I am confused on how this fixes the flaky test.. I remember seeing a comment somewhere where it was explained.. but I cannot find it now. |
Ok found it.. #1266 (comment) I still don't understand how changing the word count fixes the issue. @mcruzdev maybe you can share the sequence of things that happened and what are the expected values to make it easier to review. |
Ok for context, we are looking at the execution of this test: https://github.com/dapr/java-sdk/blob/3e54d98cf056162dc3bc237f337a359bffa8be18/examples/src/main/java/io/dapr/examples/workflows/README.md#fan-outfan-in-pattern This test executes five activities in parallel. Each activity counts the words (tokens), and then the workflow sums up all the results. The issue seems to be here:
Ok.. so changing the word count makes sense because of this: dapr/mechanical-markdown#37 |
Ok.. now I think I understand the full context.. I would recommend to change the output For example.. we can just add a period at the end and match with the period, for example: 'Activity returned: 2.' Those two will not clash when compared by mechanical markdown right? @mcruzdev Does this make sense? |
Yes, it makes sense 😅 |
a606832
to
c5ba0d6
Compare
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this!
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> Co-authored-by: Cassie Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> Co-authored-by: Cassie Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com>
* supporting appHttpPipelines for middleware Signed-off-by: salaboy <Salaboy@gmail.com> * adding test with inline string Signed-off-by: salaboy <Salaboy@gmail.com> * fixing checkstyle Signed-off-by: salaboy <Salaboy@gmail.com> * adding license hearders and TODO references Signed-off-by: salaboy <Salaboy@gmail.com> * Move dependency management and plugin management to parent pom (#1260) * Clean up pom Signed-off-by: sirivarma <siri.varma@outlook.com> * downgrade dependency Signed-off-by: sirivarma <siri.varma@outlook.com> * Fix Signed-off-by: sirivarma <siri.varma@outlook.com> * Fix thigns Signed-off-by: sirivarma <siri.varma@outlook.com> * Fix class not found Signed-off-by: sirivarma <siri.varma@outlook.com> * Remove import Signed-off-by: sirivarma <siri.varma@outlook.com> * Address comments Signed-off-by: Siri Varma Vegiraju <svegiraju@microsoft.com> * cleanup Signed-off-by: Siri Varma Vegiraju <svegiraju@microsoft.com> * Fix deps Signed-off-by: siri-varma <siri.varma@outlook.com> * cleanup Signed-off-by: Siri Varma Vegiraju <svegiraju@microsoft.com> Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix deps Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix finals Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix finals Signed-off-by: siri-varma <siri.varma@outlook.com> * upgrade test containers to .5 Signed-off-by: sirivarma <siri.varma@outlook.com> * This is it Signed-off-by: sirivarma <siri.varma@outlook.com> * Fix feedback Signed-off-by: sirivarma <siri.varma@outlook.com> * Add comment Signed-off-by: sirivarma <siri.varma@outlook.com> * Add comment Signed-off-by: sirivarma <siri.varma@outlook.com> * Change to properties Signed-off-by: sirivarma <siri.varma@outlook.com> --------- Signed-off-by: sirivarma <siri.varma@outlook.com> Signed-off-by: Siri Varma Vegiraju <svegiraju@microsoft.com> Signed-off-by: siri-varma <siri.varma@outlook.com> Co-authored-by: Siri Varma Vegiraju <svegiraju@microsoft.com> Co-authored-by: salaboy <Salaboy@gmail.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: Cassie Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com> * Update docker version for CI to fix flaky tests (#1276) * update docker version for ci Signed-off-by: salaboy <Salaboy@gmail.com> * adding DOCKER_HOST to all tests Signed-off-by: salaboy <Salaboy@gmail.com> * Move dependency management and plugin management to parent pom (#1260) * Clean up pom Signed-off-by: sirivarma <siri.varma@outlook.com> * downgrade dependency Signed-off-by: sirivarma <siri.varma@outlook.com> * Fix Signed-off-by: sirivarma <siri.varma@outlook.com> * Fix thigns Signed-off-by: sirivarma <siri.varma@outlook.com> * Fix class not found Signed-off-by: sirivarma <siri.varma@outlook.com> * Remove import Signed-off-by: sirivarma <siri.varma@outlook.com> * Address comments Signed-off-by: Siri Varma Vegiraju <svegiraju@microsoft.com> * cleanup Signed-off-by: Siri Varma Vegiraju <svegiraju@microsoft.com> * Fix deps Signed-off-by: siri-varma <siri.varma@outlook.com> * cleanup Signed-off-by: Siri Varma Vegiraju <svegiraju@microsoft.com> Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix deps Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix finals Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix finals Signed-off-by: siri-varma <siri.varma@outlook.com> * upgrade test containers to .5 Signed-off-by: sirivarma <siri.varma@outlook.com> * This is it Signed-off-by: sirivarma <siri.varma@outlook.com> * Fix feedback Signed-off-by: sirivarma <siri.varma@outlook.com> * Add comment Signed-off-by: sirivarma <siri.varma@outlook.com> * Add comment Signed-off-by: sirivarma <siri.varma@outlook.com> * Change to properties Signed-off-by: sirivarma <siri.varma@outlook.com> --------- Signed-off-by: sirivarma <siri.varma@outlook.com> Signed-off-by: Siri Varma Vegiraju <svegiraju@microsoft.com> Signed-off-by: siri-varma <siri.varma@outlook.com> Co-authored-by: Siri Varma Vegiraju <svegiraju@microsoft.com> Co-authored-by: salaboy <Salaboy@gmail.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: Cassie Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com> * fixing flaky docker network Signed-off-by: salaboy <Salaboy@gmail.com> --------- Signed-off-by: salaboy <Salaboy@gmail.com> Signed-off-by: sirivarma <siri.varma@outlook.com> Signed-off-by: Siri Varma Vegiraju <svegiraju@microsoft.com> Signed-off-by: siri-varma <siri.varma@outlook.com> Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com> Co-authored-by: Siri Varma Vegiraju <svegiraju@microsoft.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: Cassie Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com> * Change CountWordsAcitivy output format due to clashing (#1279) Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> Co-authored-by: Cassie Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com> * Bump codecov/codecov-action from 4.4.1 to 5.4.0 (#1278) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.4.1 to 5.4.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.4.1...v5.4.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cassie Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com> * Bump fossas/fossa-action from 1.3.3 to 1.6.0 (#1277) Bumps [fossas/fossa-action](https://github.com/fossas/fossa-action) from 1.3.3 to 1.6.0. - [Release notes](https://github.com/fossas/fossa-action/releases) - [Commits](fossas/fossa-action@v1.3.3...v1.6.0) --- updated-dependencies: - dependency-name: fossas/fossa-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cassie Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com> * update instructions to cover podman (#1274) Signed-off-by: salaboy <Salaboy@gmail.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: Cassie Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com> * following checkstyle Signed-off-by: salaboy <Salaboy@gmail.com> --------- Signed-off-by: salaboy <Salaboy@gmail.com> Signed-off-by: sirivarma <siri.varma@outlook.com> Signed-off-by: Siri Varma Vegiraju <svegiraju@microsoft.com> Signed-off-by: siri-varma <siri.varma@outlook.com> Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com> Co-authored-by: Siri Varma Vegiraju <svegiraju@microsoft.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: Cassie Coyle <cassie@diagrid.io> Co-authored-by: Matheus Cruz <56329339+mcruzdev@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description
This pull request adjust the
mechanical-markdown
scenario due to an issue that lives onmechanical-markdown
lib.Closes #1266
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: