-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use npm-run-scripts for commandline tooling #169
base: main
Are you sure you want to change the base?
Use npm-run-scripts for commandline tooling #169
Conversation
Useful for Windows development (hence the new `cross-env` dependency). Makefile is still there in case deploy/host scripts depend on it...though it could in turn use the npm run scripts.
Also, I should note that I've tested this in the Windows Linux Sub-System (lxss; aka "ubuntu in windows"), MingW, and PowerShell. |
Seems they do not detect bash on Windows (mingw) environments.
Found and fixed a path issue when running in bash (mingw) in Windows. Should be good to go (completely) in all those scenarios now. |
Just an idea: Makefile will be just a way to run NPM scripts, so it could be replaced by fakefile |
I would like to close this out, I think #194 will supersede everything here -- so we shouldn't put any more effort into this PR. @davidlehn can you confirm? |
The Makefile will be gone. Will have to check new commands for portability. I'm guessing things like |
The code has changed quite a bit. This patch needs to be updated if it's still an issue. |
Useful for Windows development (hence the new
cross-env
dependency).Makefile is still there in case deploy/host scripts depend on it...though
it could in turn use the npm run scripts.
The commands match the Makefile commands, so:
$ make test-node $ # is the same as $ npm run test-node
Let me know if it needs tweaks!