Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ClusterVolumeSpec in create_volume api #3318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for ClusterVolumeSpec in create_volume api #3318

wants to merge 1 commit into from
+430 −5

Conversation

Khushiyant
Copy link
Contributor

Closes #3254

Added following changes:

  • Added ClusterVolumeSpec in docker.types
  • Added cluster_volume_spec arg and its handling to create_volume api
  • Added tests in dockertypes_test.py and api_volume_test.py

@Khushiyant Khushiyant force-pushed the create-volume-spec branch from 392c319 to 0481954 Compare March 7, 2025 17:32
@Khushiyant
chore: add ClusterVolumeSpec--class (closes docker#3254)
4ce82d5 
Signed-off-by: Khushiyant <khushiyant2002@gmail.com>
@Khushiyant Khushiyant force-pushed the create-volume-spec branch from 0481954 to 4ce82d5 Compare March 7, 2025 17:37
@Khushiyant
Copy link
Contributor Author

@thaJeztah PTAL, The integration test is failing in a different pipeline that is unrelated to the applied changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ClusterVolumeSpec in the create_volume api
1 participant
@Khushiyant