Fix: Fixed crash that would sometimes occur when updating #16976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yair <39923744+yaira2@users.noreply.github.com>
yaira2
force-pushed
the
main
branch
2 times, most recently
from
30cea65 to
decf3da
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash that could occur during the update process of the Files launcher by improving exception handling and asynchronous operations. Key changes include:
- Returning early if the target launcher exe file doesn't exist.
- Wrapping file hash comparison and file copy operations in try-catch blocks with appropriate exception handling (COMException, IOException, and UnauthorizedAccessException).
- Adding asynchronous configuration with AsTask() and ConfigureAwait(false) for improved reliability.
Files not reviewed (1)
- src/Files.App (Package)/Package.appxmanifest: Language not supported
|
|
||
| Logger?.LogInformation("Files.App.Launcher updated."); | ||
| } | ||
| catch (COMException ex) |
There was a problem hiding this comment.
Consider handling IOException during the file copy operation as well (similar to the hash file comparison block) to ensure all potential I/O errors are caught during the copy process.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.