feat: Better RowSidePanel handling #706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ernestii
force-pushed
the
ernest/hdx-1498-lots-of-results-tables-cant-open-event-details-on-click
branch
2 times, most recently
from
4dac540 to
258eec7
Compare
MikeShi42
reviewed
Mar 25, 2025
| // Compress and decompress the value to save space in the URL | ||
| const deflateParser = createParser({ | ||
| parse: (value: string) => { | ||
| return JSON.parse(LZString.decompressFromBase64(value)) as SidePanelStack; |
There was a problem hiding this comment.
I think we should keep them user readable, that way it's easy to interact programmatically as well (people who build URLs dynamically from retool and other internal platforms for example)
ernestii
force-pushed
the
ernest/hdx-1498-lots-of-results-tables-cant-open-event-details-on-click
branch
2 times, most recently
from
f9a02b8 to
1f81214
Compare
ernestii
force-pushed
the
ernest/hdx-1498-lots-of-results-tables-cant-open-event-details-on-click
branch
from
1f81214 to
0e519bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.