[release-1.0] Properly handle events without the data field
#1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A valid CloudEvent in the CE binary protocol binding of Kafka might be composed by only Headers. KafkaConsumer doesn't call the deserializer if the value is null. That means that we get a record with a null value even though the record is a valid CloudEvent. This patch handles events without the data field properly by creating the CloudEvent object from record headers, if the above conditions apply. Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
knative-prow-robot
added
the
cla: yes
knative-prow-robot
added
size/L
Codecov Report
@@ Coverage Diff @@
## release-1.0 #1500 +/- ##
==============================================
Coverage ? 76.37%
Complexity ? 582
==============================================
Files ? 98
Lines ? 3568
Branches ? 160
==============================================
Hits ? 2725
Misses ? 634
Partials ? 209
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
pierDipi
approved these changes
Nov 17, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Nov 17, 2021
…e-extensions#1500) * Properly handle events without data field A valid CloudEvent in the CE binary protocol binding of Kafka might be composed by only Headers. KafkaConsumer doesn't call the deserializer if the value is null. That means that we get a record with a null value even though the record is a valid CloudEvent. This patch handles events without the data field properly by creating the CloudEvent object from record headers, if the above conditions apply. Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Make code simpler, handle exceptions, change method name Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> Co-authored-by: Pierangelo Di Pilato <pdipilat@redhat.com>
pierDipi
pushed a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Feb 18, 2025
Co-authored-by: serverless-qe <serverless-support@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1460