Fix double formatting on error message

Jille · k8s-publishing-bot · commit 2760f8658e0c · 2021-09-25T09:51:48.000+02:00
fmt.Errorf() was called with a message rather than a format string

Kubernetes-commit: 4c038d387c081c2a1a222adb76cbc2b0750fa520
diff --git a/controller.go b/controller.go
@@ -289,7 +289,7 @@ func (c *Controller) syncHandler(key string) error {
 	if !metav1.IsControlledBy(deployment, foo) {
 		msg := fmt.Sprintf(MessageResourceExists, deployment.Name)
 		c.recorder.Event(foo, corev1.EventTypeWarning, ErrResourceExists, msg)
-		return fmt.Errorf(msg)
+		return fmt.Errorf("%s", msg)
 	}
 
 	// If this number of the replicas on the Foo resource is specified, and the

Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,7 @@ func (c *Controller) syncHandler(key string) error {`
`289`	`289`	`if !metav1.IsControlledBy(deployment, foo) {`
`290`	`290`	`msg := fmt.Sprintf(MessageResourceExists, deployment.Name)`
`291`	`291`	`c.recorder.Event(foo, corev1.EventTypeWarning, ErrResourceExists, msg)`
`292`		`- return fmt.Errorf(msg)`
	`292`	`+ return fmt.Errorf("%s", msg)`
`293`	`293`	`}`
`294`	`294`
`295`	`295`	`// If this number of the replicas on the Foo resource is specified, and the`