Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layered navigation swatches ignore show tooltip setting #29971

Open
1 of 5 tasks
MichaelThessel opened this issue Sep 9, 2020 · 8 comments · May be fixed by #30115
Open
1 of 5 tasks

Layered navigation swatches ignore show tooltip setting #29971

MichaelThessel opened this issue Sep 9, 2020 · 8 comments · May be fixed by #30115
Assignees
@Bartlomiejsz
Labels
Area: Catalog Component: Swatches Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.3.5-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Milestone
2.5

Comments

@MichaelThessel
Copy link

Preconditions (*)

  1. 2.3.5-p2

Steps to reproduce (*)

  1. Set i.e. size attribute to show in layered navigation
  2. Set attribute to be a visual swatch
  3. Set Catalog > Catalog > Storefront > Show swatch tooltip to no

Expected result (*)

  1. The swatches in the layered navigation shouldn't show a tooltip on hover

Actual result (*)

  1. The swatches in the layered navigation show a tooltip on hover

The reason for that is in vendor/magento/module-swatches/view/frontend/templates/product/layered/renderer.phtml. As you can see there in the js initializing the swatch renderer the 'Show swatch tooltip' setting is not considered at all. Ideally data-option-tooltip-* woudn't be set either if tooltips are disabled. I checked the 2.4 code and the issue there is the same.

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Sep 9, 2020

Hi @MichaelThessel. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 9, 2020
@ajijshekh123 ajijshekh123 self-assigned this Sep 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2020

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sorry, something went wrong.

@engcom-Oscar engcom-Oscar self-assigned this Sep 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2020

Hi @engcom-Oscar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sorry, something went wrong.

@engcom-Oscar engcom-Oscar added Component: Swatches Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 10, 2020
@ghost ghost unassigned engcom-Oscar Sep 10, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 10, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-37576 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sdzhepa sdzhepa added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Sep 10, 2020
@Bartlomiejsz
Copy link
Contributor

@magento I am working on this

@Bartlomiejsz Bartlomiejsz linked a pull request Sep 19, 2020 that will close this issue
Open
4 tasks
@ghost ghost added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Sep 21, 2020
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Sep 22, 2020
@Bartlomiejsz
Fix magento#29971 - Layered navigation swatches ignore show tooltip s…
5599cdd 
…etting
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR in progress labels Sep 24, 2020
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Oct 6, 2020
@Bartlomiejsz
Fix magento#29971 - cover changes with mftf test
354ec22
@magento-engcom-team magento-engcom-team added the Reported on 2.3.5-p2 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Nov 13, 2020
@gabrieldagama gabrieldagama added this to the 2.5 milestone Jan 25, 2021
@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Jul 1, 2024 •
edited
Loading

Hi @MichaelThessel,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Screenshot 2024-07-01 at 11 55 47

The swatches in the layered navigation show a tooltip on hover

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Progress: PR in progress Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 1, 2024
@engcom-Bravo engcom-Bravo added Area: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Progress: PR in progress Progress: ready for dev labels Jul 1, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12313 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jul 1, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel moved this to Pull Request In Progress in Low Priority Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bartlomiejsz Bartlomiejsz

Labels
Area: Catalog Component: Swatches Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.3.5-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Milestone
2.5
Development

Successfully merging a pull request may close this issue.

Fix #29971 - Layered navigation swatches ignore show tooltip setting Bartlomiejsz/magento2
9 participants
@MichaelThessel @gabrieldagama @sdzhepa @Bartlomiejsz @ajijshekh123 @magento-engcom-team @engcom-Bravo @engcom-Oscar @github-jira-sync-bot