Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Inverted attribute grid system column #30235

Open
m2-assistant bot opened this issue Sep 29, 2020 · 4 comments · May be fixed by #30227
Open

[Issue] Inverted attribute grid system column #30235

m2-assistant bot opened this issue Sep 29, 2020 · 4 comments · May be fixed by #30227
Labels
Area: Admin UI Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Sep 29, 2020

This issue is automatically created based on existing pull request: #30227: Inverted attribute grid system column


Description

The Pull Request fixes small issue in product attribute grid Catalog > Products > Product Page > Add Attribute, where System column should be inverted instead displaying as is.

The System grid column is related with is_user_defined column in table, and when is_user_defined = 0 then System should be Yes and vice versa.

Manual testing scenario

  1. Create new product attribute - Stores > Attributes > Product > Add New Attribute
  2. Make sure that in Stores > Attributes > Product grid System column for the newly created attribute displayed as No
  3. Go to any backend product page and open modal attribute grid - Catalog > Products > Product Page > Add Attribute
  4. Make sure that System column is also as No there

The fix has been covered by MFTF test.

@m2-assistant m2-assistant bot added Component: Catalog Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 29, 2020
@m2-assistant m2-assistant bot linked a pull request Sep 29, 2020 that will close this issue
1 task
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 29, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 29, 2020
@ghost ghost unassigned elevinskii Oct 24, 2020
@ghost ghost added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 24, 2020
@engcom-Bravo engcom-Bravo self-assigned this Mar 7, 2024
Copy link
Author

m2-assistant bot commented Mar 7, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

Hi @elevinskii,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Manual testing scenario

  • Create new product attribute - Stores > Attributes > Product > Add New Attribute
  • Make sure that in Stores > Attributes > Product grid System column for the newly created attribute displayed as No
  • Go to any backend product page and open modal attribute grid - Catalog > Products > Product Page > Add Attribute
  • Make sure that System column is also as No there

Screenshot from 2024-03-07 12-42-52

Screenshot from 2024-03-07 12-43-33

System column is still yes there.

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Area: Admin UI Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 7, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11516 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented Mar 7, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants