Skip to content

[Issue] Add new flexbox mixins #30669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks
m2-assistant bot opened this issue Oct 27, 2020 · 3 comments
Closed
4 tasks

[Issue] Add new flexbox mixins #30669

m2-assistant bot opened this issue Oct 27, 2020 · 3 comments
Assignees
@engcom-November
Labels
Area: UI Framework Component: Frontend feature request Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: dev in progress Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 27, 2020

This issue is automatically created based on existing pull request: #30666: Add new flexbox mixins

Description (*)

This Pr is only improvement add some new flexbox mixins for reuse while developments
So frontenders can reuse it while modify or customise themes

Example when in less arrange layout
we can use .lib-flex-center(); for get flexbox basic styles instead write multiple line like before

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 27, 2020
@m2-assistant m2-assistant bot mentioned this issue Oct 27, 2020
Closed
5 tasks
@ghost ghost assigned mrtuvn Oct 27, 2020
@sdzhepa sdzhepa added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Nov 11, 2020
@magento-engcom-team magento-engcom-team added Reported on 2.4.0 Indicates original Magento version for the Issue report. and removed Reported on 2.4.x Indicates original Magento version for the Issue report. labels Nov 16, 2020
@ghost ghost unassigned mrtuvn Nov 21, 2020
@engcom-Dash engcom-Dash added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 7, 2024
@engcom-November engcom-November self-assigned this Mar 18, 2024
@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Mar 18, 2024

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Hello @mrtuvn,

Thank you for the report and collaboration!

As you are adding reusable mixins this issue can be marked as feature request.

@engcom-November engcom-November added feature request Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Component: Frontend Area: UI Framework and removed Reported on 2.4.x Indicates original Magento version for the Issue report. labels Mar 18, 2024
@engcom-Hotel engcom-Hotel moved this to In Progress in Feature Requests Backlog Aug 19, 2024
@engcom-Bravo
Copy link
Contributor

Hi,

Since the Related PR has been closed we are closing this issue.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engcom-November engcom-November

Labels
Area: UI Framework Component: Frontend feature request Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: dev in progress Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Feature Requests Backlog
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new flexbox mixins mrtuvn/magento2
6 participants
@mrtuvn @sdzhepa @magento-engcom-team @engcom-Bravo @engcom-November @engcom-Dash