Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Date Format in admin order grid when admin user is set to pt_BR (Brazilian Portuguese) locale #31020

Closed
4 tasks
nestormagento opened this issue Nov 23, 2020 · 10 comments · May be fixed by #31062
Closed
4 tasks
Assignees
Labels
Component: Backend Component: Locale Component: User Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.4.1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@nestormagento
Copy link

nestormagento commented Nov 23, 2020

Preconditions (*)

  1. Magento 2.4-develop
  2. Magento 2.4.1
  3. Admin User Locale set as Brazilian Portuguese
    30

Steps to reproduce (*)

  1. Create a Sample Order
  2. Set the Interface Locale of the Admin to Brazilian Portuguese (Go to admin -> Account Settings)
  3. Check the purchase date in the order grid in the wrong format

Expected result (*)

  1. The date should be in the format that appears on the actual order page

20

Actual result (*)

  1. Date Without any format
    1

For example, if we set the Interface Locale of the Admin to Catala (Espanya) everything works as expected.
Screenshot from 2020-11-24 11-45-29
Screenshot from 2020-11-24 11-45-49


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ X] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Nov 23, 2020

Hi @nestormagento. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@nestormagento
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @nestormagento. Thank you for your request. I'm working on Magento instance for you.

@nestormagento
Copy link
Author

The issue is reproducible on the vanilla Magento instance

  • Step 1 Set admin locale to Brazilian Portuguese
    teste2

  • Step 2 Check Purchase Date in admin order grid

301

@engcom-Alfa engcom-Alfa self-assigned this Nov 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 24, 2020

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Alfa engcom-Alfa added Reported on 2.4.1 Indicates original Magento version for the Issue report. Component: Locale Component: User Component: Backend Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 24, 2020
@engcom-Alfa engcom-Alfa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Progress: dev in progress labels Nov 24, 2020
@engcom-Alfa engcom-Alfa added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Progress: dev in progress Progress: ready for dev labels Nov 24, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-39325 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Litiano added a commit to Litiano/magento2 that referenced this issue Nov 25, 2020
Fix magento#31020.
Quoted values must not be replaced.
Quotation marks must be replaced with square brackets.

Locale pt_BR date formate is: d 'de' MMM 'de' y HH:mm:ss
The current formatting returns: D 'dd' MMM 'de' YYYY HH:mm:ss
Correct Moment.js format is: D [de] MMM [de] YYYY HH:mm:ss
@Litiano
Copy link

Litiano commented Nov 25, 2020

@nestormagento see #31062

@nestormagento
Copy link
Author

@Litiano Thanks a lot, that worked for me!

@engcom-Delta
Copy link
Contributor

Hi @nestormagento ,

Thanks for your reporting and collaboration.
We have tried to reproduce the issue in Latest 2.4-develop instance and the issue is no more reproducible.Kindly refer the screenshots.

Steps to reproduce

  1. Create a Sample Order
  2. Set the Interface Locale of the Admin to Brazilian Portuguese (Go to admin -> Account Settings)
  3. Check the purchase date in the order grid in the wrong format

Image

  1. Observe, The date should be in the format that appears on the actual order page

Image

Hence we are closing this issue.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Backend Component: Locale Component: User Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.4.1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants