Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Fix overrides.xml #39090

Open
4 of 5 tasks
m2-assistant bot opened this issue Aug 22, 2024 · 3 comments · May be fixed by #37371
Open
4 of 5 tasks

[Issue] Fix overrides.xml #39090

m2-assistant bot opened this issue Aug 22, 2024 · 3 comments · May be fixed by #37371
Assignees
@engcom-November
Labels
Component: Framework/TestFramework Issue: needs update Additional information is require, waiting for response Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: dev in progress Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 22, 2024

This issue is automatically created based on existing pull request: #37371: Fix overrides.xml

Without this fix it is impossible to use overrides.xml which declaratively changes the configuration of Magento tests

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. create any Magento module with web-api tests and an overrides.xml file (to suppress the ever-failing Magento tests)
  2. run all API tests and make sure that overrides.xml was ignored by the test framework

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Framework/TestFramework Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Aug 22, 2024
@m2-assistant m2-assistant bot linked a pull request Aug 22, 2024 that will close this issue
Open
6 tasks
@engcom-November engcom-November self-assigned this Aug 23, 2024
@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Aug 23, 2024

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Hello @duhon,

Thank you for the report and collaboration!

Please elaborate the description of the issue and add the steps to reproduce.

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Aug 26, 2024
@engcom-November engcom-November added the Issue: needs update Additional information is require, waiting for response label Aug 26, 2024
@duhon
Copy link
Contributor

duhon commented Sep 5, 2024

description of the issue

  • Without this fix it is impossible to use overrides.xml which declaratively changes the configuration of Magento tests

steps to reproduce

  • create any Magento module with web-api tests and an overrides.xml file (to suppress the ever-failing Magento tests)
  • run all API tests and make sure that overrides.xml was ignored by the test framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engcom-November engcom-November

Labels
Component: Framework/TestFramework Issue: needs update Additional information is require, waiting for response Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: dev in progress Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix overrides.xml duhon/magento2
3 participants
@duhon @engcom-Bravo @engcom-November