Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Magento 2 Tax Calculations not showing correctly on mini cart #39019

Closed
5 tasks
ashala-hapuarachchi opened this issue Aug 7, 2024 · 13 comments
Closed
5 tasks
Assignees
Labels
Area: Cart & Checkout Component: Cache Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@ashala-hapuarachchi
Copy link

Preconditions and environment

  • Magento version - 2.4.5
  • Set catalog prices to be Excluding Tax and have different tax rates per shipping region

Steps to reproduce

We have one store for Canada on our magento 2 website that show price excluding tax on the product page. Tax is only calculated at the checkout once you enter the shipping address. The calculation happens correctly here and the order summary is updated fine.

However if the customer decides to go back (lets say to the home page or any other product page) the mini basket shows same total for excluding and including tax. This even though the shipping address is now selected. You do see the correct totals on the basket page or checkout. It is just the mini basket that is facing the issue.

We initially thought it is something to do with our theme or custom modules. However going back to the default Luma theme and removing custom modules I still see the issue. One thing we did notice is that the mini-cart updates after a certain time, so it looks as if there is some sort of cache around the mini-cart and it does not refresh immediately.

If anyone has any ideas on this that would be really helpful.

Expected result

Including tax subtotal figure in mini-basket should show value with tax included.

Actual result

Including tax subtotal figure in mini-basket should shows value excluding tax.

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Aug 7, 2024

Hi @ashala-hapuarachchi. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Aug 7, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added Reported on 2.4.x Indicates original Magento version for the Issue report. Reported on 2.4.5 Indicates original Magento version for the Issue report. and removed Reported on 2.4.x Indicates original Magento version for the Issue report. labels Aug 7, 2024
@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Copy link

@engcom-Bravo
Copy link
Contributor

Hi @ashala-hapuarachchi,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is still reproducible.Kindly refer the screenshots.

Screenshot 2024-08-12 at 12 09 35

Mini cart showing value as excluding tax.

Hence confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Cache Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P3 May be fixed according to the position in the backlog. Area: Cart & Checkout labels Aug 12, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12749 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Aug 12, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ashala-hapuarachchi
Copy link
Author

Hi @engcom-Bravo,

Thanks for looking into this. Just to add something I did find out was that if you delete the mage-cache-sessid cookie and reload the page it will show the totals correctly. In case that is helpful in looking into the issue.

Thanks,
Ashala

@m2-community-project m2-community-project bot added Progress: done and removed Progress: ready for dev Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Aug 12, 2024
@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Progress: done labels Aug 12, 2024
@engcom-Bravo engcom-Bravo reopened this Aug 12, 2024
@m2-community-project m2-community-project bot added Progress: ready for dev and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Progress: done labels Aug 12, 2024
@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Progress: ready for dev labels Aug 12, 2024
@engcom-Bravo engcom-Bravo added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Progress: ready for dev labels Aug 12, 2024
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 12, 2024
@engcom-Hotel engcom-Hotel moved this to Ready for Development in Low Priority Backlog Aug 19, 2024
@engcom-Hotel engcom-Hotel moved this to Ready for Development in Low Priority Backlog Feb 24, 2025
@engcom-November
Copy link
Contributor

This issue has been resolved and is now functioning as expected. Please find the attached screenshot for reference.

Image

@engcom-November engcom-November self-assigned this Mar 3, 2025
Copy link

m2-assistant bot commented Mar 3, 2025

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

This issue has been resolved and is now functioning as expected. Please find the attached screenshot for reference.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Cart & Checkout Component: Cache Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Ready for Development
Development

No branches or pull requests

4 participants