Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] PageBuilder Banner element - upload new image button is not responding #39063

Open
1 of 5 tasks
Nurgiel opened this issue Aug 19, 2024 · 21 comments · May be fixed by #39576
Open
1 of 5 tasks

[ISSUE] PageBuilder Banner element - upload new image button is not responding #39063

Nurgiel opened this issue Aug 19, 2024 · 21 comments · May be fixed by #39576
Labels
Area: Content Component: MediaContent Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@Nurgiel
Copy link

Nurgiel commented Aug 19, 2024

Preconditions and environment

  • Magento version 2.4.7 (commerce and community)

Steps to reproduce

  1. Edit a product
  2. Scroll to and expand content section
  3. Click edit with page builder
  4. Insert a row
  5. Add Banner element to the row
  6. Hover over "Edit Banner Text" - "Upload Image" / "Select from Gallery" popup should appear.
  7. Click on "Upload Image"

Expected result

You should be able to upload images after clicking "Upload Image".

Actual result

No response when clicking "Upload Image"

Additional information

Workaround is to click on "cog wheel" to open the detailed form and there the upload image functionality works.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Aug 19, 2024

Hi @Nurgiel. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Aug 19, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sorry, something went wrong.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7 Indicates original Magento version for the Issue report. label Aug 19, 2024
@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Copy link

@engcom-Bravo
Copy link
Contributor

Hi @Nurgiel,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the attached video.

Steps to reproduce

  • Edit a product
  • Scroll to and expand content section
  • Click edit with page builder
  • Insert a row
  • Add Banner element to the row
  • Hover over "Edit Banner Text" - "Upload Image" / "Select from Gallery" popup should appear.
  • Click on "Upload Image"
Screen.Recording.2024-08-20.at.11.52.34.mov

We are able to upload the images successfully.

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Aug 20, 2024
@Nurgiel
Copy link
Author

Nurgiel commented Aug 20, 2024

@magento give me 2.4-develop instance

Copy link

Hi @Nurgiel. Thank you for your request. I'm working on Magento instance for you.

Copy link

@Nurgiel
Copy link
Author

Nurgiel commented Aug 20, 2024

Hey @engcom-Bravo ,

What you did is the workaround I mentioned. There it works fine.

I just replicated the issue again on the provided 2.4-develop instance and made a screenshot to better point out the button that is not working properly:

Screenshot_2024-08-20_09_46_20

@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Copy link

@engcom-Bravo
Copy link
Contributor

Hi @Nurgiel,

Thanks for your update.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the attached video.

Screen.Recording.2024-08-21.at.12.43.15.mov

No response when clicking "Upload Image"

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo removed the Issue: needs update Additional information is require, waiting for response label Aug 21, 2024
@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: MediaContent Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Area: Content and removed Issue: ready for confirmation labels Aug 21, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12799 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Aug 21, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@neenujosephmm
Copy link

The upload new image button not responding is in version 2.4.7. Is there any patch available for resolving it? The image is uploaded for the first time. When we try to change the uploaded image then the upload new button is not working.

@premanathvk
Copy link

premanathvk commented Sep 20, 2024

Any one know the fix for this issue? Please provide it.

@bm-eventstable
Copy link

I had a similar issue after upgrading to 2.4.7-p2. The upload image button in various areas of the admin were not responding and I was also unable to upload product images. Clearing the browser cache was the only thing that fixed it. Haven't had the issue since. one of my colleagues had to do the same.

@dtfdigital
Copy link

dtfdigital commented Oct 10, 2024

I had a similar issue after upgrading to 2.4.7-p2. The upload image button in various areas of the admin were not responding and I was also unable to upload product images. Clearing the browser cache was the only thing that fixed it. Haven't had the issue since. one of my colleagues had to do the same.

I'm experiencing this on a customers website, the product "browse to find or draw image here" section doesn't respond to a click, nor can I drag images into the slot. I have resolved our issue this morning and it was related to an addon we had that added the ability to create a file upload attribute addon / namespace was: Addon_Attributeupload Disabling this fixed our issue.

@yaroslav-drach
Copy link

yaroslav-drach commented Oct 29, 2024

As I see in Magento 2.4.7 the jQuery file uploader (jquery.fileuploader.js) has been replaced with Upply file uploader (uppy.min.js). As the result, JS logic into vendor/magento/module-ui/view/base/web/js/form/element/file-uploader.js has been changed.

Seems there is a mistake in the function replaceInputTypeFile when click event is binding to first button .file-uploader-button:first. Magento takes into account only "Upload Image" button inside container .pagebuilder-image-empty-preview like on Image content type when image is not uploaded yet (see file vendor/magento/module-page-builder/view/adminhtml/web/template/form/element/uploader/preview/image.html), but forgets about button in toolbar that is shown on hover for such content types like Banner, Slider and Image (when previously the image has been already uploaded).

Possible fix is below.

Before fix

replaceInputTypeFile: function (fileInput) {
    let fileId = fileInput.id, fileName = fileInput.name,
        spanElement = '<span id=\'' + fileId + '\'></span>';

    $('#' + fileId).closest('.file-uploader-area').attr('upload-area-id', fileName);
    $(fileInput).replaceWith(spanElement);
    $('#' + fileId).closest('.file-uploader-area').find('.file-uploader-button:first').on('click', function () {
        $('#' + fileId).closest('.file-uploader-area').find('.uppy-Dashboard-browse').trigger('click');
    });
}

After fix

replaceInputTypeFile: function (fileInput) {
    let fileId = fileInput.id, fileName = fileInput.name,
        spanElement = '<span id=\'' + fileId + '\'></span>';

    $('#' + fileId).closest('.file-uploader-area').attr('upload-area-id', fileName);
    $(fileInput).replaceWith(spanElement);
    $('#' + fileId).closest('.file-uploader-area').find('.file-uploader-button:first').on('click', function () {
        $('#' + fileId).closest('.file-uploader-area').find('.uppy-Dashboard-browse').trigger('click');
    });
+   $('#' + fileId).closest('.pagebuilder-image-uploader-container').find('.pagebuilder-options .file-uploader-button:first').on('click', function () {
+       $('#' + fileId).closest('.file-uploader-area').find('.uppy-Dashboard-browse').trigger('click');
+   });
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Content Component: MediaContent Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
8 participants