Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS Block listing page doesn't work for admin users with limited permissions #39665

Open
1 of 5 tasks
ihor-sviziev opened this issue Feb 27, 2025 · 11 comments · May be fixed by #39666
Open
1 of 5 tasks

CMS Block listing page doesn't work for admin users with limited permissions #39665

ihor-sviziev opened this issue Feb 27, 2025 · 11 comments · May be fixed by #39666
Assignees
Labels
Area: Content Component: Cms Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Reported on 2.4.7-p4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Feb 27, 2025

Preconditions and environment

  • Magento version 2.4.7-p4
  • Admin user with restricted permissions for merchandising only (allowed only to manage categories, products, cms blocks, cms pages). Important: you need to un-select "Edit Page Design" under "Save Page"

Steps to reproduce

  1. Go to Admin
  2. Login with user, with "merchandising" permissions
  3. Go to Content > Elements > Blocks

Expected result

You should see the CMS blocks list

Actual result

You see the magento error page with a report number.
In logs you have following:

Magento\Framework\Exception\LocalizedException: The "componentType" configuration parameter is required for the "cms_page_columns" component. in /var/www/html/vendor/magento/framework/View/Element/UiComponentFactory.php:405
Stack trace:
#0 /var/www/html/vendor/magento/framework/View/Element/UiComponentFactory.php(425): Magento\Framework\View\Element\UiComponentFactory->mergeMetadataItem(Array, Array, false)
#1 /var/www/html/vendor/magento/framework/View/Element/UiComponentFactory.php(334): Magento\Framework\View\Element\UiComponentFactory->mergeMetadataItem(Array, Array, false)
#2 /var/www/html/vendor/magento/framework/View/Element/UiComponentFactory.php(231): Magento\Framework\View\Element\UiComponentFactory->mergeMetadata('cms_block_listi...', Array, false)
#3 /var/www/html/vendor/magento/framework/View/Layout/Generator/UiComponent.php(140): Magento\Framework\View\Element\UiComponentFactory->create('cms_block_listi...', NULL, Array)
#4 /var/www/html/vendor/magento/framework/View/Layout/Generator/UiComponent.php(103): Magento\Framework\View\Layout\Generator\UiComponent->generateComponent(Object(Magento\Framework\View\Layout\Data\Structure\Interceptor), 'cms_block_listi...', Array, Object(Magento\Framework\View\Layout\Interceptor))
#5 /var/www/html/vendor/magento/framework/View/Layout/GeneratorPool.php(93): Magento\Framework\View\Layout\Generator\UiComponent->process(Object(Magento\Framework\View\Layout\Reader\Context), Object(Magento\Framework\View\Layout\Generator\Context))
#6 /var/www/html/vendor/magento/framework/View/Layout.php(365): Magento\Framework\View\Layout\GeneratorPool->process(Object(Magento\Framework\View\Layout\Reader\Context), Object(Magento\Framework\View\Layout\Generator\Context))
#7 /var/www/html/generated/code/Magento/Framework/View/Layout/Interceptor.php(32): Magento\Framework\View\Layout->generateElements()
#8 /var/www/html/vendor/magento/framework/View/Layout/Builder.php(129): Magento\Framework\View\Layout\Interceptor->generateElements()
#9 /var/www/html/vendor/magento/framework/View/Page/Builder.php(65): Magento\Framework\View\Layout\Builder->generateLayoutBlocks()
#10 /var/www/html/vendor/magento/framework/View/Layout/Builder.php(65): Magento\Framework\View\Page\Builder->generateLayoutBlocks()
#11 /var/www/html/vendor/magento/framework/View/Layout.php(271): Magento\Framework\View\Layout\Builder->build()
#12 /var/www/html/vendor/magento/framework/View/Layout.php(896): Magento\Framework\View\Layout->build()
#13 /var/www/html/vendor/magento/module-backend/Model/View/Result/Page.php(26): Magento\Framework\View\Layout->getBlock('menu')
#14 /var/www/html/vendor/magento/module-cms/Controller/Adminhtml/Block.php(42): Magento\Backend\Model\View\Result\Page->setActiveMenu('Magento_Cms::cm...')
#15 /var/www/html/vendor/magento/module-cms/Controller/Adminhtml/Block/Index.php(43): Magento\Cms\Controller\Adminhtml\Block->initPage(Object(Magento\Backend\Model\View\Result\Page\Interceptor))
...
#32 /var/www/html/vendor/magento/framework/App/FrontController.php(245): Magento\Cms\Controller\Adminhtml\Block\Index\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#33 /var/www/html/vendor/magento/framework/App/FrontController.php(212): Magento\Framework\App\FrontController->getActionResponse(Object(Magento\Cms\Controller\Adminhtml\Block\Index\Interceptor), Object(Magento\Framework\App\Request\Http))
#34 /var/www/html/vendor/magento/framework/App/FrontController.php(147): Magento\Framework\App\FrontController->processRequest(Object(Magento\Framework\App\Request\Http), Object(Magento\Cms\Controller\Adminhtml\Block\Index\Interceptor))
#35 /var/www/html/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\FrontController->dispatch(Object(Magento\Framework\App\Request\Http))
#36 /var/www/html/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\FrontController\Interceptor->___callParent('dispatch', Array)
#37 /var/www/html/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#38 /var/www/html/generated/code/Magento/Framework/App/FrontController/Interceptor.php(23): Magento\Framework\App\FrontController\Interceptor->___callPlugins('dispatch', Array, Array)
#39 /var/www/html/vendor/magento/framework/App/Http.php(116): Magento\Framework\App\FrontController\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#40 /var/www/html/vendor/magento/framework/App/Bootstrap.php(264): Magento\Framework\App\Http->launch()
#41 /var/www/html/pub/index.php(30): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http\Interceptor))
#42 {main}

Additional information

It wasn't these before installing the latest security patch.

Looks like root cause is in this commit: 3bebcd6#diff-3a204359fbffa83d59f68d531d829555fbc84decc5b9fbdd0e8a780cd81516a5R127-R143

The code is expected to be called only for CMS Page listing, while it's also runner for CMS block listing.

Workaround

Add the "Edit Page Design" permission

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Feb 27, 2025

Hi @ihor-sviziev. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@ihor-sviziev ihor-sviziev added the Reported on 2.4.7-p4 Indicates original Magento version for the Issue report. label Feb 27, 2025
@ihor-sviziev ihor-sviziev changed the title Magento 2.4.7-p4 breaks cms blocks listing page for limited admin users CMS blocks listing page doesn't work for limited admin users Feb 27, 2025
@ihor-sviziev ihor-sviziev changed the title CMS blocks listing page doesn't work for limited admin users CMS Block listing page doesn't work for limited admin users Feb 27, 2025
@ihor-sviziev ihor-sviziev changed the title CMS Block listing page doesn't work for limited admin users CMS Block listing page doesn't work for admin users with limited permissions Feb 27, 2025
@engcom-Bravo engcom-Bravo self-assigned this Feb 28, 2025
Copy link

m2-assistant bot commented Feb 28, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sorry, something went wrong.

@engcom-Bravo
Copy link
Contributor

Hi @ihor-sviziev,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

Image Image

We are able to view the CMS block list and there were no errors in logs.Could you please let us know if we are missing anything.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Feb 28, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Feb 28, 2025
@ihor-sviziev
Copy link
Contributor Author

ihor-sviziev commented Feb 28, 2025

@engcom-Bravo, just to clarify - you need to un-select "edit page design". I added it to description

@engcom-Bravo
Copy link
Contributor

Hi @ihor-sviziev,

Thanks for your update.

We have tried to reproduce the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Image

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Component: Cms Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Area: Content and removed Issue: needs update Additional information is require, waiting for response labels Mar 3, 2025
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14087 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Mar 3, 2025

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@Mohamed-Asar
Copy link
Contributor

@magento i'm working on this

@ihor-sviziev
Copy link
Contributor Author

@Mohamed-Asar, I already provided a pull request with a fix #39666

Copy link

m2-assistant bot commented Mar 5, 2025

Hi @ihor-sviziev. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@Mohamed-Asar
Copy link
Contributor

@ihor-sviziev oops sorry, i didn't notice your PR, i will close my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Content Component: Cms Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Reported on 2.4.7-p4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
4 participants