URL Rewrites that begin with letters "pub" fail to rewrite/redirect

[sean-cognella]

Preconditions and environment

• version 2.4.7-p4
• normal deployment which uses /pub/ directory for all the static content with latest .htaccess in both the root dir and /pub/ dir

Steps to reproduce

To reproduce:

• Navigate to admin
• Marketing -> SEO & Search -> URL Rewrites

Add URL Rewrite with:

• Custom a Request Path value that begins with three letters: pub (e.g. public-facing-url-that-breaks-sad-cry, publishing-is-so-wonderful.html)
• Target Path that points at a product detail page
• Redirect Type: No

Expected result

https://exampleurl.com/public-facing-url-that-breaks-sad-cry loads the product defined by Target Path

Actual result

https://exampleurl.com/public-facing-url-that-breaks-sad-cry does not the product defined by Target Path and fails with a 404 error page

Additional information

knowing how there are both apache .htaccess rewrites plus magento rewrites, it can get a bit messy to figure out where the issue is happening. we were able to trace the problem back to some very old laminas code in: vendor/laminas/laminas-http/src/PhpEnvironment/Request.php

This is the fix we implemented to get things working as one possible option though it does mean we will now have to re-apply the patch after each deployment to ensure it doesn't revert, so perhaps there is a better way you all can come up with to solve for this issue.

         // Directory portion of base path matches.
         $baseDir = str_replace('\\', '/', dirname($baseUrl));
-        if (0 === strpos($requestUri, $baseDir)) {
-            return $baseDir;
+       if (0 === strpos($requestUri, $baseDir)) {
+            // BEGIN CUSTOM
+            // Skip only if baseDir is exactly "pub" or "/pub"
+            if (!in_array($baseDir, ['pub', '/pub'], true)) {
+               return $baseDir;
+            }
+            // END CUSTOM
         }

Maybe there's a more robust or alternative option to fix this more elegantly. Thanks!

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @sean-cognella. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[engcom-Bravo]

Hi @sean-cognella,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue i9n latest 2.4-develop instance and we are able to reproduce the issue.Kindly refer the screenshots.

fails with a 404 error page.

Hence Confirming the issue.

Thanks.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14296 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.