issue #25003 fixed

[anujwebkul]

Wrong currency symbol in creditmemo_grid & sales_order_view > creditmemo grid for Adjustment Refund & Adjustment Fee columns

Description (*)

For Columns Adjustment Refund & Adjustment Fee in creditmemo_grid & sales_order_view > credit memo grid if the order is placed with the different currency.

Fixed Issues (if relevant)

1. Fixes Wrong currency symbol in creditmemo grid for Adjustment Refund & Adjustment Fee #25003 : Wrong currency symbol in creditmemo_grid & sales_order_view > credit memo grid for Adjustment Refund & Adjustment Fee Columns

Manual testing scenarios (*)

1. Set USD as Base Currency
2. Set INR currency for different store
3. Place an order from INR Currency store.
4. Go to Backend > SALES > Credit Memos, create Credit Memo with Adjustment Refund & Adjustment Fee
5. Check Adjustment Refund & Adjustment Fee column on Credit Memo grid (sales_creditmemo_index) & sales_order_view > credit memo grid.

Questions or comments

Finally, Adjustment Refund & Adjustment Fee columns value is showing correctly currency symbol.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @anujwebkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[anujwebkul]

@joni-jones Please review this PR.

[rodrigowebjump]

@magento give me test instance

[magento-engcom-team]

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @rodrigowebjump, here is your new Magento instance.
Admin access: https://pr-25004.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[AleksLi]

I found where is the issue.
You simply can compare sales_invoice_grid and sales_creditmemo_grid column by column and you will see that there is no currency_code tables in creditmemo_grid table at all. But it should take the currency_code from there to show it in the grid.
I've found that \Magento\Sales\Api\Data\CreditmemoInterface::setBaseCurrencyCode has currency_code in their interface.

Also I've found out there is nothing in db_schema.xml for the creditmemo table.
My question is why? What that some kind of idea to make that in the other way?

But on version 2.3.5 of Magento 2 this is still an issue.

[orlangur]

@magento run all tests