Added progress bar to multiple shipping address checkout

[rav-redchamps]

Description (*)

Progress bar was missing on multiple shipping address checkout so added it.

After:

Before:

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

1. Add any two products to the cart
2. Use "Check Out with Multiple Addresses" option from cart

Questions or comments

None

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @rav-redchamps. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[rav-redchamps]

@magento run all tests

[rogyar]

Hi @rav-redchamps. Could I kindly ask you to cover your changes with an MFTF test, please?
The main idea of the MFTF test is to go to the multishipping checkout and make sure that the progress bar is there.

Thank you!

[rav-redchamps]

@rogyar Sure will do.

Also, what about static test fail

https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/29045/a63931d14cac24ada97099d8ac3cd07e/Statics/allure-report-b2b/index.html#categories/a682a4a0a77e467c12b697f19023767c/7a090f189905edec/

with error

Layout file '/var/www/html/app/code/Magento/Multishipping/view/frontend/layout/multishipping_checkout.xml' uses following blocks that are not marked with @api annotation:
Magento\Multishipping\Block\Checkout\State

[rogyar]

Hi @rav-redchamps. I believe you may skip it for now. Such decisions as marking classes as @api should be considered by Magento architects rather than during a refactoring. Thank you.

[sidolov]

@rav-redchamps changes look good to me! Please, cover changes with MFTF test and we will proceed with delivery

[engcom-Golf]

Hi, @rav-redchamps!
Would you be able to proceed with covering changed logic with MFTF test?

[rav-redchamps]

Hi, @rav-redchamps!
Would you be able to proceed with covering changed logic with MFTF test?

Hi @engcom-Golf I want to, but not getting enough time these days. If someone else want to takeover & cover it with the test then please feel free to.

[engcom-Golf]

I will cover these PR changes with autotest.

[engcom-Golf]

@magento run all tests

[engcom-Golf]

@magento run all tests

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-8284 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

Hi @rav-redchamps .

During tesing, we faced the issue.

Problem: All messages appear above the progress bar

Manual testing scenario:

1. Enable Table Rate shipping method;
2. Go to Storefront;
3. Add product to cart;
4. Go to Shopping Cart;
5. Go to Checkout with Multiple Addresses;
6. Go to Shipping Information step;
7. Click on the Continue to Billing Information button;

Actual Result: ✖️ Error message appears above the progress bar

Expected Result: ✔️ On the Single Address checkout all messages appear under the progress bar

and another question is whether we need Order Success and Order Results steps if the order creation process ends at the Place Order step?

@rav-redchamps Could you take a look?

Thanks!

Pull Request state was updated. Re-review required.

[engcom-Hotel]

@magento run all tests