-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added category products grid filter by column Product Type (Issue #28885) #29366
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @engcom-Kilo. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento run all tests |
@magento run Static Tests |
@magento run Functional Tests B2B |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ I see nothing wrong with this PR. Let's wait for tests to pass, but we shouldn't have any issues there.
Hi @lbajsarowicz, thank you for the review. |
@magento run all tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ I already approved changes, not sure why I need to re-approve these.
As far as I see - everything looks correct.
Hi @lbajsarowicz, thank you for the review. |
@lbajsarowicz seems like status is incorrect. Could you approve it again and make sure it will be moved to correct status? |
@gabrieldagama @sidolov could you check why this PR isn't going to "ready for testing" status? |
Hi @ihor-sviziev, thank you for the review. |
@ihor-sviziev it has not approved EE pull request. I'll take a look at it and move to the appropriate column. |
@sidolov still PR didn't moved |
Hi @ihor-sviziev , related PR is not ready yet, that's why PR still in current state. |
@sidolov so seems like it should have status "waiting related pull requests", or the logic has changed ? |
@ihor-sviziev , yes, just moved it manually, EE pull request was re-created few times, looks like it's caused incorrect status |
Description (*)
Added category products grid filter by column Product Type.
Related Pull Requests
https://github.com/magento/partners-magento2ee/pull/390
Fixed Issues (if relevant)
Fixes #28885
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)