Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added category products grid filter by column Product Type (Issue #28885) #29366

Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

engcom-Kilo
Copy link
Contributor

@engcom-Kilo engcom-Kilo commented Aug 3, 2020

Description (*)

Added category products grid filter by column Product Type.

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/390

Fixed Issues (if relevant)

Fixes #28885

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 3, 2020

Hi @engcom-Kilo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@lbajsarowicz
Copy link
Contributor

@magento run all tests

@engcom-Kilo
Copy link
Contributor Author

@magento run all tests

@engcom-Kilo engcom-Kilo added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 3, 2020
@engcom-Kilo
Copy link
Contributor Author

@magento run Static Tests

@engcom-Kilo
Copy link
Contributor Author

@magento run Functional Tests B2B

@lbajsarowicz
Copy link
Contributor

@magento run all tests

Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ I see nothing wrong with this PR. Let's wait for tests to pass, but we shouldn't have any issues there.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7982 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Precondition:

Have products with different types

Manual testing scenario:

  1. Go to Admin -> Catalog -> Categories;
  2. Go to Products in Category tab;
  3. Try to filter products by Type

After: ✔️ The products are filtered correctly

Peek 2020-08-10 10-32

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@ghost ghost added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. labels Aug 10, 2020
@engcom-Kilo
Copy link
Contributor Author

@magento run all tests

Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ I already approved changes, not sure why I need to re-approve these.
As far as I see - everything looks correct.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7982 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

@lbajsarowicz seems like status is incorrect. Could you approve it again and make sure it will be moved to correct status?

@ihor-sviziev
Copy link
Contributor

@gabrieldagama @sidolov could you check why this PR isn't going to "ready for testing" status?

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7982 has been created to process this Pull Request

@ihor-sviziev ihor-sviziev removed their assignment Oct 15, 2020
@sidolov
Copy link
Contributor

sidolov commented Oct 15, 2020

@ihor-sviziev it has not approved EE pull request. I'll take a look at it and move to the appropriate column.

@ihor-sviziev
Copy link
Contributor

@sidolov still PR didn't moved

@sidolov
Copy link
Contributor

sidolov commented Oct 22, 2020

Hi @ihor-sviziev , related PR is not ready yet, that's why PR still in current state.

@ihor-sviziev
Copy link
Contributor

@sidolov so seems like it should have status "waiting related pull requests", or the logic has changed ?

@sidolov
Copy link
Contributor

sidolov commented Oct 22, 2020

@ihor-sviziev , yes, just moved it manually, EE pull request was re-created few times, looks like it's caused incorrect status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: ready for testing Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Status: Waiting Related PRs
Development

Successfully merging this pull request may close these issues.

Add new filter "product type" to section where we can add products to a category
7 participants