-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inverted attribute grid system column #30227
base: 2.4-develop
Are you sure you want to change the base?
Inverted attribute grid system column #30227
Conversation
Hi @elevinskii. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento create issue |
@magento run all tests |
@magento run all tests |
Description
The Pull Request fixes small issue in product attribute grid
Catalog > Products > Product Page > Add Attribute
, whereSystem
column should be inverted instead displaying as is.The
System
grid column is related withis_user_defined
column in table, and whenis_user_defined = 0
thenSystem
should beYes
and vice versa.Manual testing scenario
Stores > Attributes > Product > Add New Attribute
Stores > Attributes > Product
gridSystem
column for the newly created attribute displayed asNo
Catalog > Products > Product Page > Add Attribute
System
column is also asNo
thereThe fix has been covered by MFTF test.
Resolved issues: