magento/magento2#28358: URL rewrites are not generated for categorie with 'Include in Menu=No' when creating a store view #30427

sodhisarab · 2020-10-10T10:56:35Z

Description (*)

Category URL rewrites not generated for those category which have "Include in Menu= No". when we create or edit a new store Url Rewrites is not creating

Related Pull Requests

Fixed Issues (if relevant)

Fixes URL rewrites are not generated for categories with "Include in Menu=No" when creating a store view #28358

Manual testing scenarios (*)

.Create a category with include in menu=no into catalog admin section.
.Create a new store view into store configuration.
Switch your store with created one.
Visit Category which you have create before

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…clude in Menu=No' when creating a store view

m2-assistant · 2020-10-10T10:56:37Z

Hi @sodhisarab. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

sivaschenko · 2020-10-10T11:26:26Z

#dmcdindia2020

sodhisarab · 2020-10-10T11:32:55Z

@magento give me test instance

magento-deployment-service · 2020-10-10T11:32:57Z

Hi @sodhisarab. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2020-10-10T11:37:23Z

Hi @sodhisarab, here is your Magento Instance: https://576118b4d7bcf842e33e1173004bd08b.instances.magento-community.engineering
Admin access: https://576118b4d7bcf842e33e1173004bd08b.instances.magento-community.engineering/admin_357e
Login: 3fc9dcd0
Password: 74abf1fc3040

sodhisarab · 2020-10-10T13:04:44Z

@magento run all tests

Fix Magento Console logs erros

gabrieldagama

Hi @sodhisarab, thanks for contributing! Please have a look at my comments below.

Also, follow our https://devdocs.magento.com/contributor-guide/contributing_dod.html#automated-tests we must cover our changes with automated tests, after addressing the changes it would be nice to add test coverage to it!

Thanks

gabrieldagama · 2020-10-12T17:12:58Z

app/code/Magento/Catalog/Model/ResourceModel/Category.php

@@ -715,7 +715,7 @@ public function getCategories($parent, $recursionLevel = 0, $sorted = false, $as
        /* @var $tree \Magento\Catalog\Model\ResourceModel\Category\Tree */
        $nodes = $tree->loadNode($parent)->loadChildren($recursionLevel)->getChildren();

-        $tree->addCollectionData(null, $sorted, $parent, $toLoad, true);
+        $tree->addCollectionData(null, $sorted, $parent, $toLoad, true, false);


Instead of change, this getCategories method wouldn't make more sense to look at the CatalogUrlRewrite plugins and use CategoryRepository there to fetch the required categories?

gabrieldagama · 2020-10-12T17:14:11Z

app/code/Magento/Catalog/Model/ResourceModel/Category/Tree.php

@@ -179,7 +180,8 @@ public function addCollectionData(
        $sorted = false,
        $exclude = [],
        $toLoad = true,
-        $onlyActive = false
+        $onlyActive = false,
+        $onlyIncludeInMenu = false


Changing an @api public method is BIC, please have a look at https://devdocs.magento.com/contributor-guide/backward-compatible-development/

hi @gabrieldagama i have added code as BIC . Please review this

@sodhisarab please, extract logic to the separate class

engcom-Charlie · 2020-10-27T11:34:17Z

@sodhisarab, could you please look at #30427 (comment) #30427 (comment)?
Thank you.

engcom-Charlie · 2020-10-29T09:28:52Z

@sodhisarab, please update your PR accordingly to #30427 (comment) #30427 (comment). Otherwise, we can't proceed with your PR.
Thank you.

sodhisarab · 2020-10-30T10:38:44Z

Ok Sir, I will update my PR accordingly your comments. Thanks & Regards

…

On Thu, Oct 29, 2020 at 2:59 PM Vadim Malesh ***@***.***> wrote: @sodhisarab <https://github.com/sodhisarab>, please update your PR accordingly to #30427 (comment) <#30427 (comment)> #30427 (comment) <#30427 (comment)>. Otherwise, we can't proceed with your PR. Thank you. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30427 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALZHTM5PXUDT34APYDESC3DSNEYWJANCNFSM4SK7TNFQ> .

sodhisarab · 2020-10-30T10:55:33Z

@magento run all tests

engcom-Charlie · 2020-11-06T09:13:21Z

Hi @sodhisarab, could you please look at #30427 (comment)?
Thank you.

engcom-Charlie · 2020-11-09T08:39:49Z

@sodhisarab I'll continue with your PR.

engcom-Charlie · 2020-11-09T09:22:11Z

@magento run all tests

…r creating a store view

engcom-Charlie · 2020-11-10T18:25:02Z

@magento run all tests

engcom-Charlie · 2020-11-11T08:42:09Z

@magento run all tests

app/code/Magento/Catalog/Model/ResourceModel/Category.php

sidolov · 2020-11-16T21:38:30Z

app/code/Magento/Catalog/Model/ResourceModel/Category/Tree.php

@@ -179,7 +180,8 @@ public function addCollectionData(
        $sorted = false,
        $exclude = [],
        $toLoad = true,
-        $onlyActive = false
+        $onlyActive = false,
+        $onlyIncludeInMenu = false


@sodhisarab please, extract logic to the separate class

engcom-Charlie · 2020-11-17T11:18:13Z

@sidolov In the new method addCollectionDataParams there are using a lot of protected properties and looks like it will be difficult to extract this logic to separate class as you wrote #30427 (comment).
Could you please take a look?
Thank you.

engcom-Charlie · 2020-11-17T11:18:38Z

@magento run all tests

magento#28358: URL rewrites are not generated for categories with 'In…

44d1ebf

…clude in Menu=No' when creating a store view

ghost added the Progress: pending review label Oct 10, 2020

magento-engcom-team added Component: Catalog Release Line: 2.4 labels Oct 10, 2020

Update Category.php

3403f39

magento-engcom-team added the Event: dmcdindia2020 label Oct 10, 2020

sivaschenko added Priority: P2 Severity: S2 labels Oct 10, 2020

sodhisarab added 3 commits October 12, 2020 10:17

Update Category.php

660b0fb

Fix Magento Console logs erros

Update Category.php

1f6f3ff

Update Category.php

bc28211

gabrieldagama suggested changes Oct 12, 2020

View reviewed changes

ghost assigned gabrieldagama Oct 12, 2020

ghost added Progress: needs update and removed Progress: pending review labels Oct 12, 2020

engcom-Charlie self-assigned this Oct 27, 2020

sodhisarab added 2 commits October 30, 2020 16:21

Update Tree.php

88c8aaa

Update Category.php

5202a5b

sodhisarab added 2 commits October 30, 2020 18:27

Update Tree.php

c974fe5

Update TreeTest.php

37a60cb

m2-community-project bot added the Progress: needs update label Nov 4, 2020

engcom-Charlie added 2 commits November 9, 2020 10:40

Merge branch '2.4-develop' into fix-for-28358-categroy-url-issue

e6f93dd

revert old method behavior, refactor

5f9c440

engcom-Charlie added 3 commits November 10, 2020 11:57

Merge branch '2.4-develop' into fix-for-28358-categroy-url-issue

afc18a2

fix generate URL rewrites for category with 'Include in Menu=No' afte…

18e46f2

…r creating a store view

add integration test

43d26e7

engcom-Charlie added 2 commits November 11, 2020 10:39

Merge branch '2.4-develop' into fix-for-28358-categroy-url-issue

749ea9a

fix unit tests

ffb4cee

engcom-Charlie requested a review from gabrieldagama November 12, 2020 08:47

m2-community-project bot added Progress: pending review and removed Progress: needs update labels Nov 12, 2020

sidolov requested changes Nov 16, 2020

View reviewed changes

m2-community-project bot assigned sidolov Nov 16, 2020

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Nov 16, 2020

engcom-Charlie added 3 commits November 17, 2020 11:20

Merge branch '2.4-develop' into fix-for-28358-categroy-url-issue

a92024f

move new method to separate class

9f9470d

fix unit

5800b49

m2-community-project bot added Progress: review and removed Progress: needs update labels Nov 17, 2020

engcom-Charlie requested a review from sidolov November 17, 2020 11:18

m2-community-project bot added Progress: pending review and removed Progress: review labels Nov 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

magento/magento2#28358: URL rewrites are not generated for categorie with 'Include in Menu=No' when creating a store view #30427

magento/magento2#28358: URL rewrites are not generated for categorie with 'Include in Menu=No' when creating a store view #30427

sodhisarab commented Oct 10, 2020 •

edited

Loading

m2-assistant bot commented Oct 10, 2020

sivaschenko commented Oct 10, 2020

sodhisarab commented Oct 10, 2020

magento-deployment-service bot commented Oct 10, 2020

magento-deployment-service bot commented Oct 10, 2020

sodhisarab commented Oct 10, 2020

gabrieldagama left a comment

gabrieldagama Oct 12, 2020

gabrieldagama Oct 12, 2020

sodhisarab Oct 30, 2020

sidolov Nov 16, 2020

engcom-Charlie commented Oct 27, 2020

engcom-Charlie commented Oct 29, 2020

sodhisarab commented Oct 30, 2020 via email

sodhisarab commented Oct 30, 2020

engcom-Charlie commented Nov 6, 2020

engcom-Charlie commented Nov 9, 2020

engcom-Charlie commented Nov 9, 2020

engcom-Charlie commented Nov 10, 2020

engcom-Charlie commented Nov 11, 2020

sidolov Nov 16, 2020

engcom-Charlie commented Nov 17, 2020

engcom-Charlie commented Nov 17, 2020

magento/magento2#28358: URL rewrites are not generated for categorie with 'Include in Menu=No' when creating a store view #30427

Are you sure you want to change the base?

magento/magento2#28358: URL rewrites are not generated for categorie with 'Include in Menu=No' when creating a store view #30427

Conversation

sodhisarab commented Oct 10, 2020 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Oct 10, 2020

sivaschenko commented Oct 10, 2020

sodhisarab commented Oct 10, 2020

magento-deployment-service bot commented Oct 10, 2020

magento-deployment-service bot commented Oct 10, 2020

sodhisarab commented Oct 10, 2020

gabrieldagama left a comment

Choose a reason for hiding this comment

gabrieldagama Oct 12, 2020

Choose a reason for hiding this comment

gabrieldagama Oct 12, 2020

Choose a reason for hiding this comment

sodhisarab Oct 30, 2020

Choose a reason for hiding this comment

sidolov Nov 16, 2020

Choose a reason for hiding this comment

engcom-Charlie commented Oct 27, 2020

engcom-Charlie commented Oct 29, 2020

sodhisarab commented Oct 30, 2020 via email

sodhisarab commented Oct 30, 2020

engcom-Charlie commented Nov 6, 2020

engcom-Charlie commented Nov 9, 2020

engcom-Charlie commented Nov 9, 2020

engcom-Charlie commented Nov 10, 2020

engcom-Charlie commented Nov 11, 2020

sidolov Nov 16, 2020

Choose a reason for hiding this comment

engcom-Charlie commented Nov 17, 2020

engcom-Charlie commented Nov 17, 2020

sodhisarab commented Oct 10, 2020 •

edited

Loading