Cover AmqpStore module with unit tests #30660

mbvb1223 · 2020-10-27T10:18:47Z

Description (*)

Cover AmqpStore module with unit tests

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Cover AmqpStore module with unit tests #30671: Cover AmqpStore module with unit tests

m2-assistant · 2020-10-27T10:18:49Z

Hi @mbvb1223. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mbvb1223 · 2020-10-27T10:22:40Z

@magento run all tests

lbajsarowicz

🟡 Thank you for your input. Could you also cover other scenarios when $proceed is not called?

mbvb1223 · 2020-10-27T10:28:02Z

Thank you for your input. Could you also cover other scenarios when $proceed is not called?

Sure, I am adding more test cases to cover 100% code for this module.

sidolov · 2020-10-27T19:22:01Z

@magento create issue

mbvb1223 · 2020-10-28T07:57:47Z

@magento run Static Tests

mbvb1223 · 2020-10-29T02:49:57Z

app/code/Magento/AmqpStore/Plugin/Framework/Amqp/Bulk/Exchange.php

@@ -83,9 +83,6 @@ public function beforeEnqueue(SubjectExchange $subject, $topic, array $envelopes
        $updatedEnvelopes = [];
        foreach ($envelopes as $envelope) {
            $properties = $envelope->getProperties();
-            if (!isset($properties)) {


$properties is always array so I removed this logic
https://github.com/mbvb1223/magento2/blob/5d2f2e87a6f23db0483a53d445bbf055826c022a/lib/internal/Magento/Framework/MessageQueue/Envelope.php#L29

mbvb1223 · 2020-10-29T02:55:58Z

...gento/AmqpStore/Test/Unit/Plugin/AsynchronousOperations/MassConsumerEnvelopeCallbackTest.php

+
+        return [
+            [['store_id' => 123], $storeId, $currentStoreId],
+            [new AMQPTable(['store_id' => 123]), $storeId, $currentStoreId],


I created a new object AMQPTable because I could not create a mock and mock for the final method "getNativeData"

Do you have any suggestions for this?

https://github.com/mbvb1223/magento2/blob/1e675494b29424bed5d2183e85b4f619cf6e4c47/app/code/Magento/AmqpStore/Plugin/AsynchronousOperations/MassConsumerEnvelopeCallback.php#L75

slavvka · 2020-10-29T16:02:20Z

@magento run all tests

slavvka · 2020-10-29T16:16:41Z

@magento run all tests

lbajsarowicz

✔️ Thank you for your contribution. In general, your changes are correct. Please consider applying the suggested comments.

lbajsarowicz · 2020-11-01T15:16:43Z

...gento/AmqpStore/Test/Unit/Plugin/AsynchronousOperations/MassConsumerEnvelopeCallbackTest.php

+
+        $isProceedCalled = false;
+        $proceed = function ($message) use (&$isProceedCalled) {
+            $isProceedCalled = !!$message;


I don't think !!$message is a good option for marking if $proceed was called. Simply true is good enough.

Suggested change

$isProceedCalled = !!$message;

$isProceedCalled = true;

Thank you for the suggestion.

In this case, if I use $isProceedCalled = true; then $message is not used anywhere and can be warned a coding convention (and maybe I need to use // @SuppressWarnings(PHPMD.UnusedFormalParameter)).

Also, I want to confirm that $message was put as a parameter on $proceed($message);

Ak, maybe it is better if we change to $isProceedCalled = ($message instanceof EnvelopeInterface);

Haha, it is the same :D
I will leave the code as-is.

...gento/AmqpStore/Test/Unit/Plugin/AsynchronousOperations/MassConsumerEnvelopeCallbackTest.php

…ions/MassConsumerEnvelopeCallbackTest.php Co-authored-by: Lukasz Bajsarowicz <lukasz.bajsarowicz@gmail.com>

magento-engcom-team · 2020-11-03T17:23:27Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-8417 has been created to process this Pull Request

magento-engcom-team · 2020-11-03T17:23:29Z

@mbvb1223 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

mbvb1223 · 2020-11-07T15:09:14Z

@magento run all tests

Adding unit tests for MassConsumerEnvelopeCallback

913ef88

ghost added the Progress: pending review label Oct 27, 2020

magento-engcom-team added Component: AmqpStore Release Line: 2.4 labels Oct 27, 2020

lbajsarowicz suggested changes Oct 27, 2020

View reviewed changes

ghost assigned lbajsarowicz Oct 27, 2020

ghost added Progress: needs update and removed Progress: pending review labels Oct 27, 2020

mbvb1223 marked this pull request as draft October 27, 2020 10:23

sidolov added Priority: P3 Severity: S3 labels Oct 27, 2020

m2-assistant bot mentioned this pull request Oct 27, 2020

[Issue] Cover AmqpStore module with unit tests #30671

Open

4 tasks

binhtd-smartosc added 2 commits October 28, 2020 13:35

30671 - adding unit test for Exchange

db3a9bf

30671 - fix logic isset $properties

3cbbaed

binhtd-smartosc and others added 3 commits October 28, 2020 16:04

30671 - reduce use namespace

f452fb7

30671 - refactor code

52148e5

Merge branch '2.4-develop' into cover-amqp-store-with-unit-tests

d3f2765

mbvb1223 commented Oct 29, 2020

View reviewed changes

ghost added Progress: review and removed Progress: needs update labels Oct 29, 2020

mbvb1223 commented Oct 29, 2020

View reviewed changes

mbvb1223 marked this pull request as ready for review October 29, 2020 03:09

mbvb1223 mentioned this pull request Oct 29, 2020

[Reorder] #30686 - Allow developers to filter order items for reorder #30687

Closed

4 tasks

mbvb1223 requested a review from lbajsarowicz October 29, 2020 10:42

mbvb1223 added 2 commits October 30, 2020 09:39

Merge branch '2.4-develop' into cover-amqp-store-with-unit-tests

8e6ad2e

Merge branch '2.4-develop' into cover-amqp-store-with-unit-tests

b769e70

lbajsarowicz approved these changes Nov 1, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: review labels Nov 1, 2020

lbajsarowicz added Auto-Tests: Covered Award: test coverage labels Nov 1, 2020

Update app/code/Magento/AmqpStore/Test/Unit/Plugin/AsynchronousOperat…

5bfdc03

…ions/MassConsumerEnvelopeCallbackTest.php Co-authored-by: Lukasz Bajsarowicz <lukasz.bajsarowicz@gmail.com>

ghost added Progress: review and removed Progress: ready for testing labels Nov 2, 2020

Merge branch '2.4-develop' into cover-amqp-store-with-unit-tests

b41f3c6

mbvb1223 added 4 commits November 4, 2020 10:45

Merge branch '2.4-develop' into cover-amqp-store-with-unit-tests

ca1ef2b

Merge branch '2.4-develop' into cover-amqp-store-with-unit-tests

47c75ee

Merge branch '2.4-develop' into cover-amqp-store-with-unit-tests

e5a78b7

Merge branch '2.4-develop' into cover-amqp-store-with-unit-tests

0f3f525

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cover AmqpStore module with unit tests #30660

Cover AmqpStore module with unit tests #30660

mbvb1223 commented Oct 27, 2020 •

edited

Loading

m2-assistant bot commented Oct 27, 2020

mbvb1223 commented Oct 27, 2020

lbajsarowicz left a comment

mbvb1223 commented Oct 27, 2020

sidolov commented Oct 27, 2020

mbvb1223 commented Oct 28, 2020

mbvb1223 Oct 29, 2020

mbvb1223 Oct 29, 2020

slavvka commented Oct 29, 2020

slavvka commented Oct 29, 2020

lbajsarowicz left a comment

lbajsarowicz Nov 1, 2020

mbvb1223 Nov 2, 2020 •

edited

Loading

magento-engcom-team commented Nov 3, 2020

magento-engcom-team commented Nov 3, 2020

mbvb1223 commented Nov 7, 2020

Cover AmqpStore module with unit tests #30660

Are you sure you want to change the base?

Cover AmqpStore module with unit tests #30660

Conversation

mbvb1223 commented Oct 27, 2020 • edited Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

m2-assistant bot commented Oct 27, 2020

mbvb1223 commented Oct 27, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

mbvb1223 commented Oct 27, 2020

sidolov commented Oct 27, 2020

mbvb1223 commented Oct 28, 2020

mbvb1223 Oct 29, 2020

Choose a reason for hiding this comment

mbvb1223 Oct 29, 2020

Choose a reason for hiding this comment

slavvka commented Oct 29, 2020

slavvka commented Oct 29, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

lbajsarowicz Nov 1, 2020

Choose a reason for hiding this comment

mbvb1223 Nov 2, 2020 • edited Loading

Choose a reason for hiding this comment

magento-engcom-team commented Nov 3, 2020

magento-engcom-team commented Nov 3, 2020

mbvb1223 commented Nov 7, 2020

mbvb1223 commented Oct 27, 2020 •

edited

Loading

mbvb1223 Nov 2, 2020 •

edited

Loading