-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add new flexbox mixins #30666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new flexbox mixins #30666
Conversation
Hi @mrtuvn. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento create issue |
5659090
to
f7cbe85
Compare
f7cbe85
to
6931af5
Compare
Can we have proceed on this |
6931af5
to
1b0b607
Compare
@magento run Static Tests |
@magento run all tests |
ba727cc
to
050f8ce
Compare
update update up
050f8ce
to
66aafec
Compare
Rebased PR branch with mainline magento code branch |
@magento run all tests |
@magento run Magento Health Index |
Hi @ihor-sviziev, thank you for the review.
|
Update flex prefix
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
…o add-new-mixins-utilities
Hi @mrtuvn, We are closing this PR.The PR is in Draft since longtime. Once you are ready Please feel free to reopen it to process the PR further. Thanks |
Description (*)
This Pr is only improvement add some new flexbox mixins for reuse while developments
So FE devs can reuse it while modify or customise themes
Example when in less arrange layout
we can use .lib-flex-center(); for get flexbox basic styles instead write multiple line like before
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: