Skip to content

Add new flexbox mixins #30666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Oct 27, 2020

Description (*)

This Pr is only improvement add some new flexbox mixins for reuse while developments
So FE devs can reuse it while modify or customise themes

Example when in less arrange layout
we can use .lib-flex-center(); for get flexbox basic styles instead write multiple line like before

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Add new flexbox mixins #30669: Add new flexbox mixins

@m2-assistant
Copy link

m2-assistant bot commented Oct 27, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 27, 2020
@sidolov
Copy link
Contributor

sidolov commented Oct 27, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Oct 27, 2020
4 tasks
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 3, 2020

Can we have new proceed on this
This no need require automated tests
@krzksz @Leland can you review this

@mrtuvn mrtuvn force-pushed the add-new-mixins-utilities branch from 5659090 to f7cbe85 Compare November 10, 2020 15:37
@mrtuvn mrtuvn force-pushed the add-new-mixins-utilities branch from f7cbe85 to 6931af5 Compare November 18, 2020 16:48
@mrtuvn mrtuvn mentioned this pull request Nov 18, 2020
5 tasks
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 19, 2020

Can we have proceed on this

@mrtuvn mrtuvn force-pushed the add-new-mixins-utilities branch from 6931af5 to 1b0b607 Compare November 19, 2020 00:58
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 19, 2020

@magento run Static Tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 19, 2020

@magento run all tests

@mrtuvn mrtuvn force-pushed the add-new-mixins-utilities branch 2 times, most recently from ba727cc to 050f8ce Compare November 26, 2020 00:25
update


update


up
@mrtuvn mrtuvn force-pushed the add-new-mixins-utilities branch from 050f8ce to 66aafec Compare December 13, 2020 02:46
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Dec 13, 2020

Rebased PR branch with mainline magento code branch

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Dec 13, 2020

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Dec 13, 2020

@magento run Magento Health Index

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8619 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 12, 2021
Update flex prefix
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 21, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Nov 21, 2021

@magento run
Functional Tests EE,
Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn mrtuvn marked this pull request as draft March 20, 2023 14:21
@engcom-Bravo
Copy link
Contributor

Hi @mrtuvn,

We are closing this PR.The PR is in Draft since longtime.

Once you are ready Please feel free to reopen it to process the PR further.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests improvement Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Add new flexbox mixins
5 participants