Skip to content

Inconsistent labels for attributes in marketing rules #31231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 5, 2025
Merged

Inconsistent labels for attributes in marketing rules #31231

merged 13 commits into from
Mar 5, 2025

Conversation

DmitryFurs
Copy link
Contributor

@DmitryFurs DmitryFurs commented Dec 9, 2020 •
edited by m2-assistant bot
Loading

Description (*)

In task MAGETWO-94407, functionality was added for correct operation of marketing rules with configurable products. But additional labels for attributes are inconsistent. Some of them do not contain spaces, and some have a different style of writing words, some uppercase, and some uppercase letters.

Related Pull Requests

db41fab#diff-f4e77b2225e395e85ad967f315970b77f1557e94c2033038091750b2d4e11382

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Create Cart Price Rule or Catalog Price Rule rule
  2. Add Product attribute combination section
  3. Сheck the category and attribute options

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Inconsistent labels for attributes in marketing rules #31232: Inconsistent labels for attributes in marketing rules

@m2-assistant
Copy link

m2-assistant bot commented Dec 9, 2020

Hi @DmitryFurs. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Dec 9, 2020
@sidolov
Copy link
Contributor

sidolov commented Dec 9, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 9, 2020
Closed
4 tasks
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Jan 21, 2021
@ihor-sviziev ihor-sviziev self-assigned this Jan 21, 2021
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests EE, Static Tests

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8703 has been created to process this Pull Request

@DmitryFurs
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@DmitryFurs
Copy link
Contributor Author

DmitryFurs commented Feb 7, 2022 •
edited
Loading

Hi @ihor-sviziev @sidolov!
it looks like the linked issue #31232 is closed, and the last comment says that the problem was fixed in 2.4.3, but the pull request was not merged, and this problem is still present in the code.

Maybe you need to re-open the issue? Thanks!

@engcom-Delta
Copy link
Contributor

Hi @DmitryFurs , Thanks for your contribution.Please resolve the conflicts to move ahead on this PR

@DmitryFurs
Copy link
Contributor Author

@engcom-Delta the conflict has been resolved.

@ihor-sviziev ihor-sviziev removed their assignment Aug 16, 2024
@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Feb 12, 2025
@ihor-sviziev ihor-sviziev added Progress: ready for testing QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) and removed Progress: pending review QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Feb 12, 2025
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @DmitryFurs,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Create Cart Price Rule or Catalog Price Rule rule
  • Add Product attribute combination section
  • Сheck the category and attribute options

Before: ✖️ 

Screenshot 2025-02-13 at 11 34 22 am

After: ✔️

Screenshot 2025-02-13 at 11 46 35 am

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Charlie engcom-Charlie self-assigned this Feb 13, 2025
@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Charlie
Copy link
Contributor

As the build is green now, moving it to Merge In Progress.

image

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit c6d8743 into magento:2.4-develop Mar 5, 2025
1 check passed
@engcom-Bravo engcom-Bravo moved this from Merge in Progress to Recently Merged in Community Dashboard Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev

Assignees

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: SalesRule Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: ready for testing Project: Community Picked PRs upvoted by the community Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Community Dashboard
Status: Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Inconsistent labels for attributes in marketing rules
9 participants
@DmitryFurs @sidolov @ihor-sviziev @magento-engcom-team @engcom-Delta @engcom-Bravo @engcom-Charlie @magento-devops-reposync-svc @Priyakshic