Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed frontend resize for product configurations images #31274

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

pierm8
Copy link

@pierm8 pierm8 commented Dec 14, 2020

Description (*)

When creating new configurations from the configurable product page wizard, the images of the configurations are not resized on the frontend via javascript before uploading. This is caused by a misconfiguration of the jQuery File Upload widget.
I copied the options from the media-uploader.js file (app/code/Magento/Backend/view/adminhtml/web/js/media-uploader.js).

Manual testing scenarios (*)

  1. Go in the New product page
  2. Fill in the required fields
  3. Click on Create configurations button
  4. In the wizard select an attribute and one or more attribute values
  5. In the third step, in the Images section, select Apply single set of images to all SKUs
  6. Select an image to upload (must have width greater than 1920px or height greater than 1200px)
  7. The preview dimensions will have a maximum width of 1920px and a maximum height of 1200px. (without this fix the preview has the same dimensions as the original image).

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fixed frontend resize for product configurations images #31293: Fixed frontend resize for product configurations images

@m2-assistant
Copy link

m2-assistant bot commented Dec 14, 2020

Hi @pierm8, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@pierm8 pierm8 reopened this Dec 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 14, 2020

Hi @pierm8. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@pierm8
Copy link
Author

pierm8 commented Dec 14, 2020

@magento run all tests

@pierm8
Copy link
Author

pierm8 commented Dec 14, 2020

@magento run all tests

@gabrieldagama
Copy link
Contributor

@magento create issue

@gabrieldagama gabrieldagama added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: ConfigurableProduct Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Fixed frontend resize for product configurations images
3 participants