-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated readme file for Ui, Ups, UrlRewrite, UrlRewriteGraphQl, User, and Usps #31483
base: 2.4-develop
Are you sure you want to change the base?
updated readme file for Ui, Ups, UrlRewrite, UrlRewriteGraphQl, User, and Usps #31483
Conversation
Hi @chiranjeevi-cj. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
app/code/Magento/Ui/README.md
Outdated
- Magento_Store | ||
- Magento_User | ||
|
||
Before disabling or uninstalling this module, please consider the following dependencies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have seen my other reviews. "please consider" > "note"
app/code/Magento/Ui/README.md
Outdated
- `view/base/layout`: | ||
- `default` | ||
|
||
For more information about a layout in Magento 2, see the [Layout documentation](https://devdocs.magento.com/guides/v2.4/frontend-dev-guide/layouts/layout-overview.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I have mentioned in other review, no need to mention "Magento 2"
|
||
- Magento_CatalogUrlRewriteGraphQl | ||
|
||
Please find here [how to enable or disable modules in Magento 2](https://devdocs.magento.com/guides/v2.4/install-gde/install/cli/install-cli-subcommands-enable.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all the instances of "Please"
app/code/Magento/Ui/README.md
Outdated
|
||
The Magento\Ui module introduces a set of common UI components, which could be used and configured via layout XML files. | ||
The **Magento_Ui** module introduces a set of common UI components, which could be used and configured via layout XML files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And again, no need to bold the module names anywhere. Please remove them.
Hi @sidolov, thank you for the review.
|
…es-readme-starts-with-u
Hi @chiranjeevi-cj, Thank you for your contribution! @dobooth, I have merged 2.4-develop into this branch and it seems that all other changes requested by you have been taken care. Requesting you for the review. Thank you! |
Description (*)
Update README.md file:
Fixed Issues (if relevant)
Contribution checklist (*)