Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 32257 #32258

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Conversation

ihorvansach
Copy link
Contributor

Description (*)

This pull request fixes the issue #32257 related to Translate Inline.

Fixed Issues (if relevant)

  1. Fixes Translate Inline does not work on second translate #32257

Manual testing scenarios (*)

See #32257

Questions or comments

The difference that in Magento2.4.2 when enable Translate inline e.g. Add to cart button (other elements too) start looking as

<button type="button"
                            title="{{{Add to Cart2}}{{Add to Cart2}}{{Add to Cart2}}{{Add to Cart}}{{themeMagento/luma}}}"
                            class="action tocart primary">
                        <span>{{{Add to Cart2}}{{Add to Cart2}}{{Add to Cart2}}{{Add to Cart}}{{themeMagento/luma}}}</span>
                    </button>

And e.g. in previus Magento2.3.3 it was

<button type="button"
                            title="{{{Add to Cart2}}{{Add to Cart2}}{{Add to Cart}}{{themeMagento/luma}}}"
                            class="action tocart primary">
                        <span>{{{Add to Cart2}}{{Add to Cart2}}{{Add to Cart}}{{themeMagento/luma}}}</span>
                    </button>

And this is related to additional renderer in \Magento\Framework\Phrase\RendererInterface\Composite::render(), previously there was 3 renders:
Magento\Framework\Phrase\Renderer\Translate
Magento\Framework\Phrase\Renderer\Placeholde
Magento\Framework\Phrase\Renderer\Inline

And new renderer Magento\Framework\Phrase\Renderer\MessageFormatter was added and that leads to additional {{}} element, so need to change REGEXP_TOKEN

Contribution checklist (*)

  • [+] Pull request has a meaningful description of its purpose
  • [+] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Feb 23, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 23, 2021

Hi @ihorvansach. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Feb 23, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Feb 24, 2021

CC: @navarr

@ihorvansach
Copy link
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Translate Component: Translation Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate Inline does not work on second translate
3 participants