Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This pull request fixes the issue #32257 related to Translate Inline.
Fixed Issues (if relevant)
Manual testing scenarios (*)
See #32257
Questions or comments
The difference that in Magento2.4.2 when enable Translate inline e.g. Add to cart button (other elements too) start looking as
And e.g. in previus Magento2.3.3 it was
And this is related to additional renderer in \Magento\Framework\Phrase\RendererInterface\Composite::render(), previously there was 3 renders:
Magento\Framework\Phrase\Renderer\Translate
Magento\Framework\Phrase\Renderer\Placeholde
Magento\Framework\Phrase\Renderer\Inline
And new renderer Magento\Framework\Phrase\Renderer\MessageFormatter was added and that leads to additional {{}} element, so need to change REGEXP_TOKEN
Contribution checklist (*)