Issue 32793 Add has_options and required_options to grapql Product Interface #33125

karyna-t · 2021-06-02T13:45:44Z

Description (*)

Add has_options and required_options to grapql ProductInterface

Fixed Issues (if relevant)

Fixes Attributes has_options and required_options are not available in GraphQL #32793

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…terface

m2-assistant · 2021-06-02T13:45:46Z

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

karyna-t · 2021-07-14T16:19:41Z

@magento run all tests

magento-automated-testing · 2021-07-14T16:19:45Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

karyna-t · 2021-07-21T13:08:34Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-07-21T13:08:41Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13

Hi @karyna-tsymbal-atwix, could you please review the minor suggestion below?
Thank you.

eduard13 · 2021-07-22T04:25:24Z

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductHasOptionsTest.php

+namespace Magento\GraphQl\Catalog;
+
+use Magento\TestFramework\TestCase\GraphQlAbstract;
+


Please add a class description

eduard13 · 2021-07-22T04:25:35Z

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductHasOptionsTest.php

+    /**
+     * @magentoApiDataFixture Magento/Catalog/_files/product_simple_with_custom_options.php
+     */
+    public function testHasOptionsAndRequiredOptionsAttribute()


Suggested change

public function testHasOptionsAndRequiredOptionsAttribute()

public function testHasOptionsAndRequiredOptionsAttribute(): void

eduard13 · 2021-07-22T04:26:06Z

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductHasOptionsTest.php

+        self::assertArrayHasKey('has_options', $response['products']['items'][0]);
+        self::assertArrayHasKey('required_options', $response['products']['items'][0]);


Suggested change

self::assertArrayHasKey('has_options', $response['products']['items'][0]);

self::assertArrayHasKey('required_options', $response['products']['items'][0]);

$this->assertArrayHasKey('has_options', $response['products']['items'][0]);

$this->assertArrayHasKey('required_options', $response['products']['items'][0]);

eduard13 · 2021-07-22T04:26:32Z

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductHasOptionsTest.php

+  products(filter: {sku: {eq: "{$productSku}"}}) {
+    items {
+      sku
+	  has_options


Suggested change

has_options

has_options

…nd-required-options-to-grapql-product-interface

karyna-t · 2021-07-22T15:36:50Z

@magento run all tests

magento-automated-testing · 2021-07-22T15:36:54Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

karyna-t · 2021-07-22T18:10:21Z

@magento run Integration Tests

magento-automated-testing · 2021-07-22T18:10:28Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

karyna-t · 2021-07-22T20:20:45Z

@magento run Functional Tests EE

magento-automated-testing · 2021-07-22T20:20:53Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-07-23T04:51:54Z

Hi @eduard13, thank you for the review.
ENGCOM-9160 has been created to process this Pull Request

magento-engcom-team · 2021-07-27T04:22:29Z

Hi @Den4ik, thank you for the review.
ENGCOM-9160 has been created to process this Pull Request

cpartica · 2021-07-27T16:17:32Z

app/code/Magento/CatalogGraphQl/etc/schema.graphqls

@@ -123,6 +123,8 @@ interface ProductInterface @typeResolver(class: "Magento\\CatalogGraphQl\\Model\
    categories: [CategoryInterface] @doc(description: "The categories assigned to a product.") @resolver(class: "Magento\\CatalogGraphQl\\Model\\Resolver\\Categories") @cache(cacheIdentity: "Magento\\CatalogGraphQl\\Model\\Resolver\\Category\\CategoriesIdentity")
    canonical_url: String @doc(description: "Relative canonical URL. This value is returned only if the system setting 'Use Canonical Link Meta Tag For Products' is enabled") @resolver(class: "Magento\\CatalogGraphQl\\Model\\Resolver\\Product\\CanonicalUrl")
    media_gallery: [MediaGalleryInterface] @doc(description: "An array of Media Gallery objects.") @resolver(class: "Magento\\CatalogGraphQl\\Model\\Resolver\\Product\\MediaGallery")
+    has_options: Boolean @doc(description: "Indicates whether additional options have been created for the product.")


shouldn't this be wrapped in an interface?
we do have CustomizableProductInterface and this can be used as a fragment
in this interface we have
options: [CustomizableOptionInterface]
which has_options can be as simple as is_empty(options)
and required_options will be inside CustomizableOptionInterface for each option required: Boolean
So what is the real need for these 2 fields what we can't achieve it the existing way?

Issue 32793 Add has_options and required_options to grapql Product In…

5cfc9bc

…terface

magento-engcom-team added Component: CatalogGraphQl Release Line: 2.4 Partner: Atwix partners-contribution labels Jun 2, 2021

m2-community-project bot added the Progress: pending review label Jun 2, 2021

m2-community-project bot assigned eduard13 Jul 22, 2021

eduard13 reviewed Jul 22, 2021

View reviewed changes

m2-community-project bot added Progress: review and removed Progress: pending review labels Jul 22, 2021

eduard13 added the Auto-Tests: Covered label Jul 22, 2021

karyna-t added 2 commits July 22, 2021 18:24

Merge branch 'magento:2.4-develop' into issue-32793-add-has-options-a…

54730d6

…nd-required-options-to-grapql-product-interface

Improve code style

9576465

eduard13 approved these changes Jul 23, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Jul 23, 2021

eduard13 added the Priority: P2 label Jul 23, 2021

Den4ik approved these changes Jul 27, 2021

View reviewed changes

m2-community-project bot assigned Den4ik Jul 27, 2021

cpartica reviewed Jul 27, 2021

View reviewed changes

m2-community-project bot assigned cpartica Jul 27, 2021

m2-community-project bot added Progress: review and removed Progress: ready for testing labels Jul 27, 2021

m2-community-project bot added Progress: pending review and removed Progress: review labels Dec 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 32793 Add has_options and required_options to grapql Product Interface #33125

Issue 32793 Add has_options and required_options to grapql Product Interface #33125

karyna-t commented Jun 2, 2021

m2-assistant bot commented Jun 2, 2021

karyna-t commented Jul 14, 2021

magento-automated-testing bot commented Jul 14, 2021

karyna-t commented Jul 21, 2021

magento-automated-testing bot commented Jul 21, 2021

eduard13 left a comment

eduard13 Jul 22, 2021

eduard13 Jul 22, 2021

eduard13 Jul 22, 2021

eduard13 Jul 22, 2021

karyna-t commented Jul 22, 2021

magento-automated-testing bot commented Jul 22, 2021

karyna-t commented Jul 22, 2021

magento-automated-testing bot commented Jul 22, 2021

karyna-t commented Jul 22, 2021

magento-automated-testing bot commented Jul 22, 2021

magento-engcom-team commented Jul 23, 2021

magento-engcom-team commented Jul 27, 2021

cpartica Jul 27, 2021

		namespace Magento\GraphQl\Catalog;

		use Magento\TestFramework\TestCase\GraphQlAbstract;

	public function testHasOptionsAndRequiredOptionsAttribute()
	public function testHasOptionsAndRequiredOptionsAttribute(): void

		self::assertArrayHasKey('has_options', $response['products']['items'][0]);
		self::assertArrayHasKey('required_options', $response['products']['items'][0]);

Issue 32793 Add has_options and required_options to grapql Product Interface #33125

Are you sure you want to change the base?

Issue 32793 Add has_options and required_options to grapql Product Interface #33125

Conversation

karyna-t commented Jun 2, 2021

Description (*)

Fixed Issues (if relevant)

Contribution checklist (*)

m2-assistant bot commented Jun 2, 2021

karyna-t commented Jul 14, 2021

magento-automated-testing bot commented Jul 14, 2021

karyna-t commented Jul 21, 2021

magento-automated-testing bot commented Jul 21, 2021

eduard13 left a comment

Choose a reason for hiding this comment

eduard13 Jul 22, 2021

Choose a reason for hiding this comment

eduard13 Jul 22, 2021

Choose a reason for hiding this comment

eduard13 Jul 22, 2021

Choose a reason for hiding this comment

eduard13 Jul 22, 2021

Choose a reason for hiding this comment

karyna-t commented Jul 22, 2021

magento-automated-testing bot commented Jul 22, 2021

karyna-t commented Jul 22, 2021

magento-automated-testing bot commented Jul 22, 2021

karyna-t commented Jul 22, 2021

magento-automated-testing bot commented Jul 22, 2021

magento-engcom-team commented Jul 23, 2021

magento-engcom-team commented Jul 27, 2021

cpartica Jul 27, 2021

Choose a reason for hiding this comment