Fix Shipping iterate over null #34187

thomas-kl1 · 2021-09-29T09:24:25Z

Description (*)

This is continuing the #30822 MR

If there is no carriers available on the store (no carriers modules), an iteration on null occurs.

Also there's a proposal to deprecate 'active flag' from shipping and carrier models. It turns out that the active method from the abstract carrier always looks for 'active' config field and the 'active flag' only adds unnecessary noise.

Related Pull Requests

#30822

m2-assistant · 2021-09-29T09:24:27Z

Hi @thomas-kl1. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

thomas-kl1 · 2021-09-30T21:26:10Z

@magento run all tests

magento-automated-testing · 2021-09-30T21:26:15Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

thomas-kl1 · 2021-09-30T21:26:20Z

@magento run all tests

magento-automated-testing · 2021-09-30T21:26:24Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-10-01T05:50:14Z

app/code/Magento/Shipping/Model/Shipping.php

-                \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
-                $storeId
-            );
+            $carriers = $this->_shippingConfig->getCarriersConfig($storeId);

            foreach ($carriers as $carrierCode => $carrierConfig) {
                $this->collectCarrierRates($carrierCode, $request);


just curious why not use method public getAllCarriers in app/code/Magento/Shipping/Model/Config.php

seem i see some regression code here with change public to private method cc: @engcom-Charlie

@mrtuvn you mean private to public, that's not a regression

We don't use the getAllCarriers method because we don't need the carrier model to be instantiated

app/code/Magento/Shipping/Model/Config.php

thomas-kl1 · 2021-12-15T14:26:56Z

@magento run all tests

magento-automated-testing · 2021-12-15T14:27:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

thomas-kl1 · 2022-07-27T12:41:43Z

@magento give me test instance

magento-deployment-service · 2022-07-27T12:41:46Z

Hi @thomas-kl1. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2022-07-27T12:42:40Z

Hi @thomas-kl1, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

thomas-kl1 · 2022-07-27T20:08:41Z

@magento run all tests

magento-automated-testing · 2022-07-27T20:08:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

thomas-kl1 · 2022-07-27T20:59:14Z

Static tests failed because of B2B rules https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/34187/74e5c8be9cf860b0e732d57abdcfc27a/Statics/allure-report-b2b/index.html#categories/06c3f017895259e95d5c8f6dda658ef8/df5fd6119021e001/
Not sure it makes sense here, $rateResultFactory was unused even before this PR and doc blocks are not needed in our case (proper signature type and method name is self explanatory)

thomas-kl1 · 2022-07-27T21:02:14Z

@magento run Unit Tests

magento-automated-testing · 2022-07-27T21:02:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

thomas-kl1 · 2022-08-23T13:33:31Z

@magento give me 2.3 instance

magento-deployment-service · 2022-08-23T13:33:34Z

Hi @thomas-kl1. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2022-08-23T13:37:57Z

Hi @thomas-kl1, here is your Magento Instance: https://79a626dd068562f05485604fb8dbd74b.instances.magento-community.engineering
Admin access: https://79a626dd068562f05485604fb8dbd74b.instances.magento-community.engineering/admin_7a07
Login: baa823f0
Password: cbc5c3540b45

thomas-kl1 · 2022-09-04T14:27:15Z

@magento run Unit Tests

magento-automated-testing · 2022-09-04T14:27:23Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

thomas-kl1 · 2022-09-04T16:11:31Z

@magento run all tests

magento-automated-testing · 2022-09-04T16:11:40Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

thomas-kl1 · 2022-09-04T20:44:57Z

@magento run all tests

magento-automated-testing · 2022-09-04T20:45:06Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

thomas-kl1 · 2023-03-02T20:50:55Z

@magento run all tests

magento-automated-testing · 2023-03-02T20:51:00Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team added Component: Shipping Release Line: 2.4 labels Sep 29, 2021

sidolov added the Priority: P2 label Sep 30, 2021

m2-community-project bot added the Progress: pending review label Sep 30, 2021

mrtuvn reviewed Oct 1, 2021

View reviewed changes

m2-community-project bot assigned mrtuvn Oct 1, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Oct 1, 2021

sidolov requested changes Oct 25, 2021

View reviewed changes

app/code/Magento/Shipping/Model/Config.php Outdated Show resolved Hide resolved

m2-community-project bot assigned sidolov Oct 25, 2021

m2-community-project bot added Progress: needs update Progress: review and removed Progress: review Progress: needs update labels Oct 25, 2021

thomas-kl1 force-pushed the patch-9 branch from 924ff85 to 3e702cc Compare December 15, 2021 09:03

thomas-kl1 requested a review from sidolov December 15, 2021 14:25

thomas-kl1 force-pushed the patch-9 branch from 001dc2a to 1fc749b Compare July 27, 2022 20:04

thomas-kl1 force-pushed the patch-9 branch 2 times, most recently from d598a72 to ea014a2 Compare September 4, 2022 14:18

thomas-kl1 force-pushed the patch-9 branch 2 times, most recently from 7445863 to b58dbea Compare September 4, 2022 16:11

thomas-kl1 force-pushed the patch-9 branch from b58dbea to 3337529 Compare September 4, 2022 18:10

Extract carriers status and config to separate class

42813cc

thomas-kl1 force-pushed the patch-9 branch from 3337529 to 42813cc Compare September 4, 2022 18:14

m2-community-project bot added Progress: pending review and removed Progress: review labels Dec 8, 2022

Merge branch '2.4-develop' into patch-9

389c86f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Shipping iterate over null #34187

Fix Shipping iterate over null #34187

thomas-kl1 commented Sep 29, 2021 •

edited

Loading

m2-assistant bot commented Sep 29, 2021

thomas-kl1 commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

thomas-kl1 commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

mrtuvn Oct 1, 2021 •

edited

Loading

mrtuvn Oct 1, 2021 •

edited

Loading

thomas-kl1 Oct 1, 2021

thomas-kl1 Oct 1, 2021

thomas-kl1 commented Dec 15, 2021

magento-automated-testing bot commented Dec 15, 2021

thomas-kl1 commented Jul 27, 2022

magento-deployment-service bot commented Jul 27, 2022

magento-deployment-service bot commented Jul 27, 2022

thomas-kl1 commented Jul 27, 2022

magento-automated-testing bot commented Jul 27, 2022

thomas-kl1 commented Jul 27, 2022

thomas-kl1 commented Jul 27, 2022

magento-automated-testing bot commented Jul 27, 2022

thomas-kl1 commented Aug 23, 2022

magento-deployment-service bot commented Aug 23, 2022

magento-deployment-service bot commented Aug 23, 2022

thomas-kl1 commented Sep 4, 2022

magento-automated-testing bot commented Sep 4, 2022

thomas-kl1 commented Sep 4, 2022

magento-automated-testing bot commented Sep 4, 2022

thomas-kl1 commented Sep 4, 2022

magento-automated-testing bot commented Sep 4, 2022

thomas-kl1 commented Mar 2, 2023

magento-automated-testing bot commented Mar 2, 2023

Fix Shipping iterate over null #34187

Are you sure you want to change the base?

Fix Shipping iterate over null #34187

Conversation

thomas-kl1 commented Sep 29, 2021 • edited Loading

Description (*)

Related Pull Requests

m2-assistant bot commented Sep 29, 2021

thomas-kl1 commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

thomas-kl1 commented Sep 30, 2021

magento-automated-testing bot commented Sep 30, 2021

mrtuvn Oct 1, 2021 • edited Loading

Choose a reason for hiding this comment

mrtuvn Oct 1, 2021 • edited Loading

Choose a reason for hiding this comment

thomas-kl1 Oct 1, 2021

Choose a reason for hiding this comment

thomas-kl1 Oct 1, 2021

Choose a reason for hiding this comment

thomas-kl1 commented Dec 15, 2021

magento-automated-testing bot commented Dec 15, 2021

thomas-kl1 commented Jul 27, 2022

magento-deployment-service bot commented Jul 27, 2022

magento-deployment-service bot commented Jul 27, 2022

thomas-kl1 commented Jul 27, 2022

magento-automated-testing bot commented Jul 27, 2022

thomas-kl1 commented Jul 27, 2022

thomas-kl1 commented Jul 27, 2022

magento-automated-testing bot commented Jul 27, 2022

thomas-kl1 commented Aug 23, 2022

magento-deployment-service bot commented Aug 23, 2022

magento-deployment-service bot commented Aug 23, 2022

thomas-kl1 commented Sep 4, 2022

magento-automated-testing bot commented Sep 4, 2022

thomas-kl1 commented Sep 4, 2022

magento-automated-testing bot commented Sep 4, 2022

thomas-kl1 commented Sep 4, 2022

magento-automated-testing bot commented Sep 4, 2022

thomas-kl1 commented Mar 2, 2023

magento-automated-testing bot commented Mar 2, 2023

thomas-kl1 commented Sep 29, 2021 •

edited

Loading

mrtuvn Oct 1, 2021 •

edited

Loading

mrtuvn Oct 1, 2021 •

edited

Loading