Fix overrides.xml

[duhon]

Without this fix it is impossible to use overrides.xml which declaratively changes the configuration of Magento tests

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. create any Magento module with web-api tests and an overrides.xml file (to suppress the ever-failing Magento tests)
2. run all API tests and make sure that overrides.xml was ignored by the test framework

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Fix overrides.xml #39090: Fix overrides.xml

[m2-assistant]

Hi @duhon. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[duhon]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[duhon]

@engcom-Hotel ping

[duhon]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[duhon]

@engcom-Hotel ping
very easy changes, just changing to the correct type solves an important problem of code quality. Is it really that hard to press merge?

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @duhon,

Thanks for the contribution!

Please fix the failed automated test.

Thanks

[engcom-November]

@magento create issue

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

We are internally discussing this PR. Till the time, we are moving this on hold.

[duhon]

The crash is not related to my pull request; my code does not affect the eval functionality. This is a problem with the test itself, which I don’t have access to.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @duhon,

We have noticed that this PR has not been updated for a period of long time. Hence we are closing this PR for now.

Let us know when you are ready to work on it again, and we will be happy to re-open it. Thank you for your contribution!

Thanks

[duhon]

@engcom-Hotel The PR was ready to merge, what a reason for the closure, I waited for you to merge

[m2-assistant]

Hi @duhon. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @duhon,

Thanks for reaching us!

As we talked about here and slack as well, we need a green build to continue with the PR. As the PR is failing Preliminary Checks, we are unable to proceed with this.

We request you to please resolve the failed test.

Thanks

[duhon]

Hello @duhon,

Thanks for reaching us!

As we talked about here and slack as well, we need a green build to continue with the PR. As the PR is failing Preliminary Checks, we are unable to proceed with this.

We request you to please resolve the failed test.

Thanks

The answer here.
Give me access to your test Preliminary Checks and I will fix it.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @duhon,

We are currently discussing the PR failures internally. We will update you soon on this, meanwhile moving this PR on hold.

Thanks for the patience.