Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Reorder feature #37373

Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix Reorder feature #37373

wants to merge 5 commits into from

Conversation

Kaitaka48
Copy link

@Kaitaka48 Kaitaka48 commented Apr 14, 2023 •
edited by ihor-sviziev
Loading

Open #37372

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Reorder feature allows you to purchase product from different stores on the website #37372

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 14, 2023

Hi @Kaitaka48. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@Kaitaka48 Kaitaka48 mentioned this pull request Apr 18, 2023
Open
5 tasks
nuzil
nuzil requested changes Apr 25, 2023
View reviewed changes
app/code/Magento/Sales/Controller/AbstractController/Reorder.php Outdated
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function __construct(
StoreManagerInterface $storeManager,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case if you adding new dependency, it have to go to the end of the list and also have to be backward compartible (so fallback to using ObjectManager have to be added)

app/code/Magento/Sales/Controller/AbstractController/Reorder.php
@@ -50,21 +53,25 @@ abstract class Reorder extends Action\Action implements HttpPostActionInterface
* @param ReorderHelper|null $reorderHelper
* @param \Magento\Sales\Model\Reorder\Reorder|null $reorder
* @param CheckoutSession|null $checkoutSession
* @param StoreManagerInterface|null $storeManager
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function __construct(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also refactor class in the following manner:
https://php.watch/versions/8.0/constructor-property-promotion

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out, I have corrected it with reference to the URL。
Committed.

As for Guest/Reorder.php, I have reverted it back to its original state since the above fixes did not require this part to be fixed.

@Kaitaka48 Kaitaka48 requested a review from nuzil April 26, 2023 01:44
@Kaitaka48 Kaitaka48 marked this pull request as draft April 26, 2023 02:39
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 26, 2023
@Kaitaka48 Kaitaka48 marked this pull request as ready for review May 1, 2023 06:37
@Kaitaka48 Kaitaka48 marked this pull request as draft May 2, 2023 01:48
@Kaitaka48 Kaitaka48 marked this pull request as ready for review May 2, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuzil nuzil

Assignees

@nuzil nuzil

Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review
Projects
Pull Requests Dashboard
Status: Review in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorder feature allows you to purchase product from different stores on the website
2 participants
@Kaitaka48 @nuzil