[AC-8699] Magento Pages Width does not match anymore for Long width c… #37476

adamphh · 2023-05-09T02:58:44Z

[AC-8699] Magento Pages Width does not match anymore for Long width content after 2.4.6 upgrade #37459

Description (*)

Preconditions and environment

Magento version 2.4.6

Steps to reproduce

Navigate Product Grid
Add atleast 10 more column visible from columns dropdown.
3.Scroll down till last content and then scroll right. You will see the page width did not match columns width.

Expected result

While adding more columns in any grid should match full page width. Issue was not there in 2.4.5

Related Pull Requests

Fixed Issues (if relevant)

Fixes Magento Pages Width does not match anymore for Long width content after 2.4.6 upgrade #37459

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…ontent after 2.4.6 upgrade magento#37459

m2-assistant · 2023-05-09T02:58:47Z

Hi @adamphh. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

mrtuvn · 2023-05-09T04:16:03Z

app/design/adminhtml/Magento/backend/Magento_Catalog/web/css/source/_module.less

@@ -9,6 +9,7 @@

 .catalog-product-index {
    .admin__data-grid-wrap {
+        overflow-x: scroll;
        .data-row {


in myopinion properties should overflow-x: auto instead always show scroll

@mrtuvn Thanks for your response. Yes, I think it should be auto instead of scroll. I already updated it.

@adamphh This commit only fixes product grid but this issue is happening for all the magento backend ui-grids.
@mrtuvn

@irajneeshgupta Thanks for your comment. I will resolve it

…ontent after 2.4.6 upgrade magento#37459

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

mrtuvn

looks good to me

mrtuvn · 2023-05-10T03:35:12Z

weird things i can't find/encounter this issue happen in version 2.3.7 ? Any code update after that ?

mrtuvn · 2023-05-10T03:36:41Z

mrtuvn · 2023-05-10T03:46:07Z

Seem this changes in this commit make regression issue
ba93336

mrtuvn · 2023-05-10T10:32:42Z

Hi Can you check my last comment

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

…ontent after 2.4.6 upgrade magento#37459 Update code to resolve make regression issue #ba93336

adamphh · 2023-05-11T03:21:41Z

Hi Can you check my last comment

@mrtuvn I push the new modification. Please help to check it again

mrtuvn · 2023-05-11T03:42:40Z

app/design/adminhtml/Magento/backend/Magento_Ui/web/css/source/module/_data-grid.less

@@ -429,7 +430,7 @@ body._in-resize {
    .data-grid-actions-cell {
        padding-left: @data-grid-cell__padding-horizontal * 2;
        padding-right: @data-grid-cell__padding-horizontal * 2;
-        position: relative;
+        position: inherit;
        text-align: center;


any reason of this update position

can it's work without it ?

hi @adamphh can you explain more about this changes

If no specific or special reason i suggest to remove for reduce extra css property

@mrtuvn there is no special reason for that, it can work without position, However I am not sure if it affect to another section.

app/design/adminhtml/Magento/backend/Magento_Ui/web/css/source/module/_data-grid.less

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

mrtuvn

can you check my last response

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

…oes_not_match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

[AC-8699] Magento Pages Width does not match anymore for Long width c…

b2d8432

…ontent after 2.4.6 upgrade magento#37459

m2-community-project bot added Priority: P2 Progress: pending review labels May 9, 2023

mrtuvn reviewed May 9, 2023

View reviewed changes

m2-community-project bot assigned mrtuvn May 9, 2023

m2-community-project bot added Progress: review and removed Progress: pending review labels May 9, 2023

mrtuvn added the Area: Admin UI label May 9, 2023

adamphh added 2 commits May 10, 2023 08:11

[AC-8699] Magento Pages Width does not match anymore for Long width c…

a52d128

…ontent after 2.4.6 upgrade magento#37459

Merge branch '2.4-develop' into AC-8699-magento_pages_width_does_not_…

6f9c80f

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

mrtuvn approved these changes May 10, 2023

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels May 10, 2023

m2-community-project bot assigned irajneeshgupta May 10, 2023

m2-community-project bot added Progress: review and removed Progress: ready for testing labels May 10, 2023

mrtuvn added the Progress: needs update label May 10, 2023

m2-community-project bot removed the Progress: review label May 10, 2023

adamphh added 2 commits May 11, 2023 00:02

Merge branch '2.4-develop' into AC-8699-magento_pages_width_does_not_…

3b6c820

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

[AC-8699] Magento Pages Width does not match anymore for Long width c…

da4bbd5

…ontent after 2.4.6 upgrade magento#37459 Update code to resolve make regression issue #ba93336

m2-community-project bot added Progress: review and removed Progress: needs update labels May 11, 2023

mrtuvn reviewed May 11, 2023

View reviewed changes

app/design/adminhtml/Magento/backend/Magento_Ui/web/css/source/module/_data-grid.less Show resolved Hide resolved

adamphh added 3 commits May 12, 2023 00:17

Merge branch '2.4-develop' into AC-8699-magento_pages_width_does_not_…

7163625

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

Merge branch '2.4-develop' into AC-8699-magento_pages_width_does_not_…

3f59d70

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

Merge branch '2.4-develop' into AC-8699-magento_pages_width_does_not_…

745abed

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

mrtuvn requested a review from irajneeshgupta May 17, 2023 00:07

mrtuvn requested changes May 17, 2023

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels May 17, 2023

adamphh added 2 commits May 19, 2023 05:12

Merge branch '2.4-develop' into AC-8699-magento_pages_width_does_not_…

f6b1e22

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

Merge branch '2.4-develop' into AC-8699-magento_pages_width_does_not_…

0b85bd6

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

m2-community-project bot added Progress: review and removed Progress: needs update labels May 26, 2023

adamphh added 4 commits May 26, 2023 11:23

Merge branch '2.4-develop' into AC-8699-magento_pages_width_does_not_…

545d6c6

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

Merge branch '2.4-develop' into AC-8699-magento_pages_width_does_not_…

31f7db8

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

Merge branch '2.4-develop' into AC-8699-magento_pages_width_does_not_…

0c638bc

…match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

Merge branch 'magento:2.4-develop' into AC-8699-magento_pages_width_d…

03baa13

…oes_not_match_anymore_for_long_width_content_after_2.4.6_upgrade_37459

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AC-8699] Magento Pages Width does not match anymore for Long width c… #37476

[AC-8699] Magento Pages Width does not match anymore for Long width c… #37476

adamphh commented May 9, 2023

m2-assistant bot commented May 9, 2023

mrtuvn May 9, 2023

adamphh May 10, 2023

irajneeshgupta May 10, 2023

adamphh May 11, 2023

mrtuvn left a comment

mrtuvn commented May 10, 2023

mrtuvn commented May 10, 2023

mrtuvn commented May 10, 2023

mrtuvn commented May 10, 2023

adamphh commented May 11, 2023

mrtuvn May 11, 2023

mrtuvn May 11, 2023

mrtuvn May 14, 2023

mrtuvn May 17, 2023

adamphh May 26, 2023

mrtuvn left a comment

[AC-8699] Magento Pages Width does not match anymore for Long width c… #37476

Are you sure you want to change the base?

[AC-8699] Magento Pages Width does not match anymore for Long width c… #37476

Conversation

adamphh commented May 9, 2023

Description (*)

Preconditions and environment

Steps to reproduce

Expected result

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented May 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrtuvn left a comment

Choose a reason for hiding this comment

mrtuvn commented May 10, 2023

mrtuvn commented May 10, 2023

mrtuvn commented May 10, 2023

mrtuvn commented May 10, 2023

adamphh commented May 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrtuvn left a comment

Choose a reason for hiding this comment