-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update success message on admin backend with field changed ref #38696
Update success message on admin backend with field changed ref #38696
Conversation
Hi @Franciscof-Serfe. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento I'm working on it |
Hi @Franciscof-Serfe. Thank you for your request. I'm working on Magento instance for you. |
Hi @Franciscof-Serfe, here is your Magento Instance: https://b3cd20f43b29fa6ce0b5fa97d193c818.instances-prod.magento-community.engineering |
@magento give me 2.4-develop instance |
Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you. |
Hi @Den4ik, here is your Magento Instance: https://73f7df1580919d100034e255e83e3964.instances-prod.magento-community.engineering |
27fc59f
to
36269dc
Compare
…ranciscof-Serfe/magento2 into improve-success-messages-admin-backend
…to improve-success-messages-admin-backend
@magento run all tests |
Thank you for your contribution! The Magento core engineering team is working on the issue which you have addressed in this PR. Team will cherry pick the commits from your PR and may do further implementation to cover few more scenarios as needed. We will reach out to you if we need more information. For now, you can pause work on this PR. Thank you once again! |
As mentioned here, Magento core engineering team tried to reproduce this issue and found that its not reproducible on 2.4-develop installation. It’s only reproducible on 2.4.4-p12-develop. In order to overcome this problem, we recommend you to upgrade to Magento's latest version. For now, we are closing this PR, please feel free to reopen it for any updates. |
Thank you for your contribution! The Magento core engineering team is working on the issue which you have addressed in this PR. The message will be updated according to your suggestions, while the redirection will remain unchanged. Team will cherry pick the commits from your PR and may do further implementation to cover few more scenarios as needed. We will reach out to you if we need more information. For now, you can pause work on this PR. Thanks. |
Hi @Franciscof-Serfe. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
a97b692
into
magento:2.4-develop
Hello, The PR's issue got fixed in the scope of the internal Jira ticket AC-10886 by the internal team Based on the Jira ticket, the target version is 2.4.8-beta2. Thanks |
Description (*)
In relation to this issue #38352, it was detected that the admin user when modifying some field of his account and recording it, the message he received was generic (You saved the account).
For this reason, through this PR we add the information of the modified field(s) to the success message.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Attached video of the tests
successMessage.webm
Questions or comments
FYI: Redirecting to the main dashboard was considered but since the user can decide to generate other modifications after modifying the password, that feature was rejected.
Contribution checklist (*)