-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test file to correct location #38725
Move test file to correct location #38725
Conversation
Hi @ihor-sviziev. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
Hi @ihor-sviziev, thank you for the heads up, we're looking into this. |
@magento run all tests |
Hi @ihor-sviziev, Thank you for you input and contribution! As discussed and confirmed with @bl4de, the mentioned file was created and committed into the wrong directory. Now it got moved and renamed to the correct location (and renamed). dev/tests/api-functional/testsuite/Magento/GraphQl/GraphQl/DisableSessionSetCookieTest.php is the new file. As the issue is resolved and the fix is available on the Magento 2.4 develop hence closing this PR now. Please feel free to reopen for any other updates. Thank you! |
Description (*)
In 49cc612 was added API test that was placed to the wrong directory: dev/tests/Magento/GraphQl... instead of dev/tests/api-functional/testsuite/Magento/GraphQl....
Because of wrong file location, this test won't be executed
This Pull Request moves this task to correct folder.
/CC @svera @bl4de
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)