Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test file to correct location #38725

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented May 15, 2024

Description (*)

In 49cc612 was added API test that was placed to the wrong directory: dev/tests/Magento/GraphQl... instead of dev/tests/api-functional/testsuite/Magento/GraphQl....

Because of wrong file location, this test won't be executed

This Pull Request moves this task to correct folder.
/CC @svera @bl4de

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented May 15, 2024

Hi @ihor-sviziev. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev
Copy link
Contributor Author

ihor-sviziev commented May 15, 2024

@svera @bl4de please look on the test failures, looks like delivered changes doesn't work as expected

@bl4de
Copy link
Contributor

bl4de commented May 15, 2024

Hi @ihor-sviziev, thank you for the heads up, we're looking into this.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 15, 2024
@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Sep 12, 2024
@engcom-Hotel engcom-Hotel self-requested a review September 17, 2024 10:40
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Sep 17, 2024
@engcom-Charlie engcom-Charlie self-assigned this Sep 18, 2024
@engcom-Charlie
Copy link
Contributor

Hi @ihor-sviziev,

Thank you for you input and contribution!

As discussed and confirmed with @bl4de, the mentioned file was created and committed into the wrong directory. Now it got moved and renamed to the correct location (and renamed). dev/tests/api-functional/testsuite/Magento/GraphQl/GraphQl/DisableSessionSetCookieTest.php is the new file.

As the issue is resolved and the fix is available on the Magento 2.4 develop hence closing this PR now. Please feel free to reopen for any other updates.

Thank you!

@ihor-sviziev ihor-sviziev deleted the move-test-to-correct-location branch September 19, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Community Picked PRs upvoted by the community Risk: low Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants