Disable captcha storefont config still load captcha js files

[rogerdz]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Disable captcha storefont config still load captcha js files #32987

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[rogerdz]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @rogerdz,

Thank you for the contribution!

Please address the review comments mentioned below.Additionally it appears that the failed integration and static tests are caused by the changes in this PR.

Kindly resolve those as well.

[engcom-Hotel]

We are picking this PR for further processing.

[rogerdz]

Hello @rogerdz,

Thank you for the contribution!

Please address the review comments mentioned below.Additionally it appears that the failed integration and static tests are caused by the changes in this PR.

Kindly resolve those as well.

not yet, please fix your composer repo first

[engcom-Hotel]

Hello @rogerdz,

This is a known issue and there is an ongoing discussion on this here. Please refer to this chat for further information.

In the meantime, do you want us to continue with this PR, or should we wait for the composer-related issue to be fixed and then you continue to work on this issue?

Thanks

[rogerdz]

do you want us to continue with this PR

Yes, thank you.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Static Tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Functional Tests EE, Functional Tests B2B

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @ihor-sviziev,

Thanks for approving the PR. Moving it to ready for testing bucket.

@magento run all tests

[engcom-Bravo]

Hi @rogerdz,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• Disable captcha on frontend admin

Before: ✖️ 

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests

[engcom-Dash]

Some test failures for the recent two builds for functional CE are consistent and there are the known issues and the Jira raised for the same. The one test case is flaky in functional CE.

Functional CE:

Build 1 : https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39154/066b6436deb394f71afa4d57ad0a2a87/Functional/allure-report-ce/index.html#categories/90ca0ef92eda6ba1448271cd45952684/b58cb19297139441/

Build 2 : https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39154/a4ce46a465c1bfecbd239290d4c06e41/Functional/allure-report-ce/index.html#categories/8f0831c1d06562890f5ec21062dae309/6e213b8f581a59da/

Known Issues:

StorefrontVerifySearchTermEntityRedirectTest: ACQE-7705
AdminUserApplyToSeveralSimpleProductsMassActionUnAssignProductSourcesOnProductsGridToUnAssignAllAssignedSourcesTest: ACQE-7706
AdminValidateSimpleProductWithCustomOptionsDragNDropPerPageTest: ACQE-7707

Functional EE :

The consistent failed test case has JIRA raised. Other failures are flaky.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39154/33d8bde72938ffd875c6b9e5beb5bd51/Functional/allure-report-ee/index.html#categories/8f0831c1d06562890f5ec21062dae309/48c84f74356a6d73/

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39154/4e2d21703365e1728d1f8332ed013c06/Functional/allure-report-ee/index.html#categories/8f0831c1d06562890f5ec21062dae309/165f0ea25c23621/

Functional B2B:
For Functional B2B, we will monitor one more build for the consistently failing test cases.

Known Issues:

StorefrontVerifySearchTermEntityRedirectTest: ACQE-7705

Keeping this PR in Extended testing to monitor one more Functional B2B Tests build.