-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Lighthouse scan to reach 100% Accessibility on Homepage #39164
base: 2.4-develop
Are you sure you want to change the base?
Allow Lighthouse scan to reach 100% Accessibility on Homepage #39164
Conversation
Hi @Serfe-com. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento add to contributors team |
Hi @Serfe-com! 👋 |
@magento I am working on this |
@magento I am working on this |
@magento run all tests |
https://github.com/magento run all tests |
Hi @Franciscof-Serfe. Thank you for your request. I'm working on Magento instance for you. |
Hi @Franciscof-Serfe, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later. |
@magento run all tests |
@magento run all tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app/design/frontend/Magento/blank/Magento_Swatches/web/css/source/_module.less
Outdated
Show resolved
Hide resolved
@magento run all tests |
@magento run all tests |
@magento run all tests |
@magento run all tests |
@magento run all tests |
Hi @Serfe-com, Thanks for the collaboration & contribution! ✔️ QA PassedPreconditions:
Steps to reproduce
Before: ✖️ ![]() After: ✔️ ![]() Builds are failed. Hence, moving this PR to Extended Testing. Thanks. |
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests EE |
For Functional B2B the consistent test failure is the known issue and Jira raised for the same. Hence moving this PR to Merge in Progress. Build 1: Build 2: ![]() Known Issue: AdminValidateMixedNestedCategoryInWidgetTest ACQE-7641 |
Hi Team, @engcom-Bravo @engcom-Dash @engcom-Hotel, Would it be appropriate to label this PR as Progress: ready for testing if it has already been tested? I've noticed that in other PRs, the Progress: accept label is applied after the Ready for Testing stage. Could you confirm if this is the correct status? Thank you! Best regards, |
Hi @Franciscof-Serfe We were facing some challenges with bot. I have updated the correct labels now. Thank You!! |
Description (*)
We adjust the rendering of the menu and small adjustment on the contrast for the page to allow to hit 100% on accessibility on the home, PDP y PLP on Luma
Related Pull Requests
38617
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)