Fix offline invoice capture (404)

[nige-one]

Description (*)

It's not possible to capture offline payment method invoices via the backend ('Capture' button). Trying it will lead to a 404.

Related Pull Requests

The issue comes from 3e63705#diff-f55a86b611d11bb9a801c4b16ba9ac4b17dab4c325d252b86d5d3a8b8275c291

The class has been changed to be implementing HttpPostActionInterface. Clicking the 'Capture' button will send a GET request. Magento's request validator \Magento\Framework\App\Request\HttpMethodValidator will throw an exception leading to a 404 because it expects a POST request.

Manual testing scenarios (*)

1. create an order with an offline payment method
2. create an invoice for the order (offline)
3. capture the invoice

Resolved issues:

1. resolves [Issue] Fix offline invoice capture (404) #39298: Fix offline invoice capture (404)

[m2-assistant]

Hi @nige-one. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

@magento create issue

[Syamsg]

The same issue occurs when trying to cancel an invoice, resulting in a 404 error, because its controller class Magento\Sales\Controller\Adminhtml\Order\Invoice\Cancel also implements the HttpPostActionInterface.

[Dnd-Mafer]

The culprit : 3e63705

[constancyGmbH]

can please somebody review this? This fix should be part of the core asap...

[ihor-sviziev]

@magento run all tests