Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xssFiltrationPattern boundary script tag restriction #39379

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open

xssFiltrationPattern boundary script tag restriction #39379

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
276fa92
Update ConfigurableWYSIWYGValidator.php
osrecio Nov 18, 2024
af7cdae
Merge branch '2.4-develop' into osrecio-patch-1
osrecio Nov 18, 2024
39fb503
xssFiltrationPattern boundary script tag restriction
ihor-sviziev Nov 19, 2024
1be9879
Merge branch '2.4-develop' into osrecio-patch-1
ihor-sviziev Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/internal/Magento/Framework/Test/Unit/Validator/HTML/ConfigurableWYSIWYGValidatorTest.php
View file
Original file line number Diff line number Diff line change
@@ -166,6 +166,15 @@ public static function getConfigurations(): array
[],
['div' => ['src' => false]]
],
'valid-allowed-tag-with-script-in-class-name' => [
['div'],
['class', 'src'],
[],
'<div class="product-description">this is a product description</div>',
true,
[],
['div' => ['src' => false]]
],
'invalid-allowed-tag-attributes' => [
['a'],
['href'],
2 changes: 1 addition & 1 deletion lib/internal/Magento/Framework/Validator/HTML/ConfigurableWYSIWYGValidator.php
View file
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ class ConfigurableWYSIWYGValidator implements WYSIWYGValidatorInterface
* @var string
*/
private static string $xssFiltrationPattern =
'/((javascript(\\\\x3a|:|%3A))|(data(\\\\x3a|:|%3A))|(vbscript:)|(script)|(alert\())|'
'/((javascript(\\\\x3a|:|%3A))|(data(\\\\x3a|:|%3A))|(vbscript:)|(script\b)|(alert\())|'
. '((\\\\x6A\\\\x61\\\\x76\\\\x61\\\\x73\\\\x63\\\\x72\\\\x69\\\\x70\\\\x74(\\\\x3a|:|%3A))|'
. '(\\\\x64\\\\x61\\\\x74\\\\x61(\\\\x3a|:|%3A)))/i';