leading zeros doesn't accountable in the cart for the cart price rule…

[magentoabu]

… issue fixed

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Cart price rule with condition SKU dosen't take into account the "leading zeros" in the SKU (sku: 01234 is the same as 1234) #37919

Manual testing scenarios (*)

1. Create product with SKU: 1234..
2. Create product with SKU: 01234..
3. Create CART PRICE RULE (for example):
   Specific coupon
   Coupon code: TESTSKU
   ACTION: percent of product price discount, 50% discount amount)
   Apply the rule only to cart items ... (SKU is 01234).
   4.Go to shop front and add product SKU 1234 to CART.
   5.On the cart page enter the coupon code TESTSKU.
   6.Discount for product with SKU: 1234 of 50% didn't applied.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @magentoabu. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[magentoabu]

@magento run all tests

[nuzil]

@magentoabu can you pls sign Adobe CLA?

[magentoabu]

@magentoabu can you pls sign Adobe CLA?

@nuzil ,its done as Adobe CLA signed. Thanks

[nuzil]

@magentoabu if you can, can you check Static tests? Cause you changed file, it being validated and requires some comment modifications.
Also other tests failure connected to your change

[magentoabu]

@magento run all tests

[magentoabu]

@magento run Static Tests

[magentoabu]

@magento run Static Tests

[engcom-Dash]

@magentoabu I am taking care of the changes. Thank you!

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Unit Tests, WebAPI Tests, Integration Tests, Functional Tests B2B, Functional Tests EE, Functional Tests CE

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Modified the implementation for the strings starting with "0". Also, added the unit tests. Hence moving this back to pending review.

[engcom-Hotel]

Hello @engcom-Dash & @magentoabu,

Please refer to the below review comments.

Thanks

[engcom-Dash]

@engcom-Hotel I have updated the PR with the requested changes hence moving it to the pending review. Thank You!

[engcom-Dash]

@magento run all tests

[engcom-Bravo]

@magento run all tests

[engcom-Bravo]

Hi @magentoabu,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• Create product with SKU: 1234

• Create product with SKU: 01234

• Create CART PRICE RULE (for example):

   Specific coupon
   Coupon code: TESTSKU
   ACTION: percent of product price discount, 50% discount amount)
   Apply the rule only to cart items ... (SKU is 01234)
  

• Go to shop front and add product SKU 1234 to CART

• On the cart page enter the coupon code TESTSKU

Before: ✖️ 

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

[engcom-Dash]

@magento run all tests