magento/magento2#39567: Catalog price rules with SKU using "not one of" and configurable products

[KrasnoshchokBohdan]

Description (*)

In situation with "not one of" condition in catalog rule, \Magento\CatalogRule\Model\Rule::getMatchingProductIds works ok and result array doesn't have excluded products, but as author of issue mentioned, plugin \Magento\CatalogRuleConfigurable\Plugin\CatalogRule\Model\Rule\ConfigurableProductHandler::aroundGetMatchingProductIds adds excluded products back to result array.

Related Pull Requests

--

Fixed Issues (if relevant)

1. Fixes Catalog price rules with SKU using "not one of" and configurable products #39567

Manual testing scenarios (*)

1. create a configurable product with multiple variants as simple products (or take existing one)
2. enable SKU to be used in price rules (if not set)
3. create catalog price rule, and use SKU as filter with a "not one of" option, and provide simple product SKU

Before fix:
Products including the provided SKU are affected by the price rule, because the given SKU is a sub-product of a configurable product.

After fix:
Products except the provided SKU are affected by the catalog price rule.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @KrasnoshchokBohdan,

Thanks for the contribution!

It seems the build failures are due to PR changes. Please fix those failures and also please add an automated test in accordance to DOD.

Thanks

[engcom-Charlie]

Hi @KrasnoshchokBohdan,

Thank you for your contribution!

As you have marked this Pull Request as draft, moving this PR to On Hold. Please feel free to to move it to Open state once you done with the implementation and the review mentioned here.