Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 39353 validate template vars in customer addr #39671

Conversation

rostilos
Copy link
Contributor

Description (*)

Added validation for the presence of template variables in the user address.
In the original ticket it was suggested to sanitize values, but I don't think it's really necessary. I don't think any of the address fields can contain something like {{ .... }}, so it is reasonable to add this to the validation rules.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [Address Book Bug] Template filter \Magento\Framework\Filter\Template cannot deal with improper input #39353

Manual testing scenarios (*)

  1. When creating or editing an address ( storefront/adminhtml ), enter into any of the address fields a template variable of the following form : {{if city}}{{var city}}, {{/if}}
  2. Check if there is a validation error

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Feb 28, 2025

Hi @rostilos. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels Feb 28, 2025
@rostilos rostilos force-pushed the fix-for-issue-39353-validate-template-vars-in-customer-addr branch from 7bfa4bd to 23f685d Compare February 28, 2025 12:04
@rostilos rostilos closed this Feb 28, 2025
@rostilos rostilos force-pushed the fix-for-issue-39353-validate-template-vars-in-customer-addr branch from 2d112e0 to 5de8779 Compare February 28, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Perspective partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Address Book Bug] Template filter \Magento\Framework\Filter\Template cannot deal with improper input
2 participants