Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#39651: Missing Billing Address Error in Admin Dashbo… #39678

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

MaximLogic
Copy link

Description (*)

The issue was related to creation of empty order by REST API with only one field - payment method code, after what appeared error in admin dashboard. An empty billing address for order entity can cause many errors, like the one, that is presented in related issue. In this regard, my pull request proposes to make billing address required while preserving the entity of the order.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Missing Billing Address Error in Admin Dashboard When Creating Order via REST API with Only Payment Information #39651

Manual testing scenarios (*)

  1. Generate Admin API key by sending Admin Username and Password to /rest/V1/integration/admin/token
  2. Use generated API key to send PUT request for creation of order to /rest/V1/orders/create without providing billing address (like related in issue { "entity": { "payment": { "method": "cashondelivery" } } })

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

…Creating Order via REST API with Only Payment Information

- added require for billing address in order repository save method
Copy link

m2-assistant bot commented Feb 28, 2025

Hi @MaximLogic. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels Feb 28, 2025
@MaximLogic MaximLogic closed this Feb 28, 2025
@MaximLogic MaximLogic reopened this Feb 28, 2025
@MaximLogic
Copy link
Author

@magento run all tests

…Creating Order via REST API with Only Payment Information

- fixed copyright
@MaximLogic
Copy link
Author

@magento run all tests

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 28, 2025
@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Mar 13, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MaximLogic,

Thanks for the contribution!

I can see there are multiple tests are failing due to this PR changes. I request you to please fix those also please add some automated test in accordance to DOD.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Perspective partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Project: Community Picked PRs upvoted by the community
Projects
Status: Changes Requested
6 participants