-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magento/magento2#39651: Missing Billing Address Error in Admin Dashbo… #39678
base: 2.4-develop
Are you sure you want to change the base?
Conversation
…Creating Order via REST API with Only Payment Information - added require for billing address in order repository save method
Hi @MaximLogic. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
…Creating Order via REST API with Only Payment Information - fixed copyright
@magento run all tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @MaximLogic,
Thanks for the contribution!
I can see there are multiple tests are failing due to this PR changes. I request you to please fix those also please add some automated test in accordance to DOD.
Thanks
Description (*)
The issue was related to creation of empty order by REST API with only one field - payment method code, after what appeared error in admin dashboard. An empty billing address for order entity can cause many errors, like the one, that is presented in related issue. In this regard, my pull request proposes to make billing address required while preserving the entity of the order.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
{ "entity": { "payment": { "method": "cashondelivery" } } }
)Questions or comments
Contribution checklist (*)