magento/magento2#39111: Product Collection - addMediaGalleryData call…

[Himsoft]

Description (*)

\Magento\Catalog\Model\ResourceModel\Product\Collection::addMediaGalleryData calls getSize if the collection is loaded.

• Fixed call count instead of getSize if collection is loaded.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Product Collection - addMediaGalleryData calls getSize when the collection maybe or will be loaded (Can use count to avoid an extra DB query) #39111

Manual testing scenarios (*)

1. Enable dev query log
2. Call the products GQL with the media_gallery/media_gallery_entries field selected.
3. The method (getSize or count) call should be in the query log, traced to addMediaGalleryData

Before fix:
getSize is called on a loaded product collection

After fix:
count is called on a loaded product collection

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Himsoft. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[Himsoft]

@magento run all tests

[Himsoft]

@magento run all tests

[Himsoft]

@magento run all tests

[Himsoft]

@magento run all tests

[Himsoft]

The failed tests are not related to fixes, they look like false positives, please pay attention to this during the review.